Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are Crypt filter Recipient strings always byte strings? #16

Closed
petervwyatt opened this issue Jan 7, 2021 · 2 comments
Closed

Are Crypt filter Recipient strings always byte strings? #16

petervwyatt opened this issue Jan 7, 2021 · 2 comments
Labels
ISO approved Resolved issue approved by ISO

Comments

@petervwyatt
Copy link
Member

"Table 27 — Additional crypt filter dictionary entries for public-key security handlers" Recipients key is described as being of type "string or array".

The array case is then clearly defined to be a byte string: "If the crypt filter is referenced from StmF or StrF in the encryption dictionary, this entry shall be an array of byte strings, where each string shall be a binary-encoded CMS object that shall ...".
An improvement would be to change "where each string ..." to "where each byte string ..."

However for the string case, it just says "... this entry shall be a string that shall be a binary-encoded CMS object that shall contain a list of all recipients ..."

Question: is this also required to be a byte string or is just string OK?

@petervwyatt petervwyatt added bug Something isn't working question Further information is requested and removed bug Something isn't working labels Jan 7, 2021
@lrosenthol
Copy link
Collaborator

Recommend that it should be byte string to match

@petervwyatt petervwyatt added the proposed solution Proposed solution is ready for review label Jan 9, 2021
@petervwyatt
Copy link
Member Author

Proposed solutions:

  1. "If the crypt filter is referenced from StmF or StrF in the encryption dictionary, this entry shall be an array of byte strings, where each byte string shall be a binary-encoded CMS object that shall ..."
  2. change the Type column to say "byte string or array"
  3. "... this entry shall be a byte string that shall be a binary-encoded CMS object that shall contain a list of all recipients ..."

@petervwyatt petervwyatt added ISO submitted Resolved issue submitted to ISO for approval and removed question Further information is requested proposed solution Proposed solution is ready for review labels Dec 6, 2021
@petervwyatt petervwyatt added this to the ISO Submission Feb 2022 milestone Dec 6, 2021
@petervwyatt petervwyatt added ISO approved Resolved issue approved by ISO and removed ISO submitted Resolved issue submitted to ISO for approval labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISO approved Resolved issue approved by ISO
Projects
None yet
Development

No branches or pull requests

2 participants