From f06c608fcef2302d72d1a888891c7f0a94a13f6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=96mer=20AKBA=C5=9E?= <45395318+omer-akbas@users.noreply.github.com> Date: Mon, 3 May 2021 04:01:28 +0300 Subject: [PATCH] Fix rename err Cannot change filename because the file is open (f1) and gives rename error. It must be closed before changing its name. --- pkg/api/merge.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/api/merge.go b/pkg/api/merge.go index 57777c670..2ae5c2787 100644 --- a/pkg/api/merge.go +++ b/pkg/api/merge.go @@ -182,13 +182,13 @@ func MergeAppendFile(inFiles []string, outFile string, conf *pdfcpu.Configuratio if err = f2.Close(); err != nil { return } - if f1 != nil { - if err = os.Rename(tmpFile, outFile); err != nil { + for _, f := range ff { + if err = f.Close(); err != nil { return } } - for _, f := range ff { - if err = f.Close(); err != nil { + if f1 != nil { + if err = os.Rename(tmpFile, outFile); err != nil { return } }