Permalink
Commits on Aug 11, 2016
  1. Merge pull request #375 from guilhermesimoes/master

    Add gemspec requirements attribute
    sigmavirus24 committed on GitHub Aug 11, 2016
  2. Add gemspec requirements attribute

    This information will appear on the gem's page on rubygems.org.
    http://guides.rubygems.org/specification-reference/#requirements
    
    [ci skip]
    guilhermesimoes committed Aug 11, 2016
Commits on Mar 15, 2016
  1. Merge pull request #352 from dimko/patch-2

    Minor optimizations in middleware
    sigmavirus24 committed Mar 15, 2016
Commits on Mar 14, 2016
  1. Use `Array()` instead of `[].flatten` in `middleware#conditions_as_re…

    …gexp`
    
    ```
    require 'benchmark/ips'
    conditions = %w[a long time ago in a galaxy far far away]
    
    Benchmark.ips do |x|
      x.report('[].flatten') { [conditions].flatten }
      x.report('Array()')    { Array(conditions) }
      x.compare!
    end
    
    # Warming up --------------------------------------
    #           [].flatten    49.491k i/100ms
    #              Array()   157.466k i/100ms
    # Calculating -------------------------------------
    #           [].flatten    672.181k (± 6.2%) i/s -      3.365M
    #              Array()      8.815M (± 9.5%) i/s -     43.776M
    
    # Comparison:
    #              Array():  8814545.4 i/s
    #           [].flatten:   672180.8 i/s - 13.11x slower
    ```
    dimko committed Mar 14, 2016
  2. Immediately return false in `middleware#render_as_pdf?` if the path d…

    …oesn't end with `.pdf`
    dimko committed Mar 14, 2016
  3. Use `end_with?` instead of `match` in `middleware#render_as_pdf?`

    ```
    require 'benchmark/ips'
    u = 'http://www.pdf995.com/samples/pdf.pdf'
    
    Benchmark.ips do |x|
      x.report('match')     { u.match %r[\.pdf$] }
      x.report('end_with?') { u.end_with? '.pdf' }
      x.compare!
    end
    
    # Warming up --------------------------------------
    #                match    60.612k i/100ms
    #            end_with?   136.383k i/100ms
    # Calculating -------------------------------------
    #                match    934.157k (± 6.1%) i/s -      4.667M
    #            end_with?      5.115M (± 7.3%) i/s -     25.504M
    
    # Comparison:
    #            end_with?:  5115305.0 i/s
    #                match:   934157.4 i/s - 5.48x slower
    ```
    dimko committed Mar 14, 2016
Commits on Jan 17, 2016
  1. Merge pull request #344 from ContinuityControl/honor-root-url-in-core

    Honor `root_url` in core
    sigmavirus24 committed Jan 17, 2016
  2. Merge pull request #347 from cdwort/fix_travis_again

    Address Travis issues with Bundler failures
    cdwort committed Jan 17, 2016
  3. Address Travis issues with Bundler failures

    - This issue: bundler/bundler#3558
    - PASS: Gem version 2.5.1 & Bundler 1.11.1
    - FAIL: Gem version 2.5.1 & Bundler 1.7.6
    - PASS: Gem version 2.4.3 & Bundler 1.7.6
    cdwort committed Jan 17, 2016
Commits on Jan 8, 2016
  1. Preprocess HTML in PDFKit, not PDFKit::Middleware.

    * PDFKit now supports :root_url and :protocol options, both optional.
    * Middleware passes those options to PDFKit, inferring them from the
      environment.
    * Introduces PDFKit::HTMLPreprocessor helper class.
    
    Fixes #343
    danbernier committed Jan 7, 2016
Commits on Nov 29, 2015
  1. Merge pull request #340 from reiz/patch-1

    Adding MIT license to the gemspec.
    sigmavirus24 committed Nov 29, 2015
Commits on Nov 6, 2015
Commits on Nov 5, 2015
Commits on Oct 10, 2015
  1. Merge pull request #333 from sigmavirus24/refactor

    Refactor wkhtmltopdf logic out into a separate class
    cdwort committed Oct 10, 2015
  2. Remove two unnecessary and now invalid tests

    We're far more user friendly than we were before so let's not assert
    that we can misconfigure wkhtmltopdf and pdfkit.
    Amy Unger and Ian Cordasco committed Oct 10, 2015
  3. Refactor wkhtmltopdf logic out into a separate class

    Refactor operating system specific checks and methods into a separate
    module as well.
    Amy Unger and Ian Cordasco committed Oct 10, 2015
Commits on Aug 26, 2015
  1. Merge pull request #328 from cdwort/master

    Bump to 0.8.2
    cdwort committed Aug 26, 2015
  2. Bump to 0.8.2

    cdwort committed Aug 26, 2015
  3. Merge pull request #327 from christhekeele/patch-1

    Require 'uri'
    cdwort committed Aug 26, 2015
  4. Require 'uri'

    christhekeele committed Aug 26, 2015
Commits on Aug 21, 2015
  1. Merge pull request #325 from cdwort/master

    Bump to v0.8.1
    cdwort committed Aug 21, 2015
  2. Bump to v0.8.1

    cdwort committed Aug 21, 2015
Commits on Aug 20, 2015
  1. Merge pull request #324 from cdwort/bump_to_0.8.1

    Bump to 0.8.1
    sigmavirus24 committed Aug 20, 2015
Commits on Aug 19, 2015
  1. Add CHANGELOG notes for v0.8.1

    cdwort committed Aug 19, 2015
  2. Fix release number

    cdwort committed Aug 19, 2015
Commits on Jul 16, 2015
  1. Merge pull request #312 from cdwort/do_not_shellescape_source

    Do not shellescape URLs since it borks params
    cdwort committed Jul 16, 2015
Commits on Jul 12, 2015
  1. Remove unnecessary paranoia

    cdwort committed with cdwort Jul 8, 2015