Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic orientation when using as Rack Middleware #184

Closed
lucianocosta opened this issue Jul 4, 2013 · 7 comments
Closed

Dynamic orientation when using as Rack Middleware #184

lucianocosta opened this issue Jul 4, 2013 · 7 comments

Comments

@lucianocosta
Copy link

I need to change orientation to landscape just for some pages, i.e., per request.

@miry
Copy link
Contributor

miry commented Dec 19, 2013

You can set the orientation via meta tags.

<meta name="pdfkit-orientation" content="Landscape"/>

@sigmavirus24
Copy link
Contributor

@lucianocosta does @miry's suggestion solve this for you?

@EncoreHQ
Copy link

EncoreHQ commented Aug 7, 2014

I don't know, more than a year has passed and I'm not using it currently. At that time we ended up using my fork. Do you guys see any cons to that change (match against fullpath)?

@sigmavirus24
Copy link
Contributor

If you could rebase the changes, we would be able to see if the tests pass or not. The tests were failing and I suspect using fullpath instead of path might introduce a surprise or two.

@lucianocosta
Copy link
Author

Sorry, I was logged with other account (EncoreHQ). I'll take a look on that this weekend!

@sigmavirus24
Copy link
Contributor

No need to apologize. Thanks for taking a look.

@cdwort
Copy link
Contributor

cdwort commented Jun 13, 2015

I am closing this issue as it can be resolved using meta tags and is cannot really be considered an open issue but rather a feature request that the PR #185 implements.

@cdwort cdwort closed this as completed Jun 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants