Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dynamic orientation when using as Rack Middleware #184

Closed
lucianocosta opened this Issue Jul 4, 2013 · 7 comments

Comments

Projects
None yet
5 participants

I need to change orientation to landscape just for some pages, i.e., per request.

lucianocosta added a commit to lucianocosta/pdfkit that referenced this issue Jul 4, 2013

Allowing :only and :except regular expressions to match over request.…
…fullpath - closes #184

this way I can do this via url parameter
Contributor

miry commented Dec 19, 2013

You can set the orientation via meta tags.

<meta name="pdfkit-orientation" content="Landscape"/>
Owner

sigmavirus24 commented Aug 7, 2014

@lucianocosta does @miry's suggestion solve this for you?

EncoreHQ commented Aug 7, 2014

I don't know, more than a year has passed and I'm not using it currently. At that time we ended up using my fork. Do you guys see any cons to that change (match against fullpath)?

Owner

sigmavirus24 commented Aug 7, 2014

If you could rebase the changes, we would be able to see if the tests pass or not. The tests were failing and I suspect using fullpath instead of path might introduce a surprise or two.

Sorry, I was logged with other account (EncoreHQ). I'll take a look on that this weekend!

Owner

sigmavirus24 commented Aug 9, 2014

No need to apologize. Thanks for taking a look.

Contributor

cdwort commented Jun 13, 2015

I am closing this issue as it can be resolved using meta tags and is cannot really be considered an open issue but rather a feature request that the PR #185 implements.

@cdwort cdwort closed this Jun 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment