Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow options with empty value #125

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Owner

devn commented Feb 22, 2013

What is the use case for this?

Owner

devn commented May 10, 2013

@magnushoerberg I'm running through PRs and would like to bump this. I feel like there might be a valid use-case for this but in general it feels unnecessary. Could you explain why this would be a good thing? Truthy string literals should be handled by consumers of this library, not the library itself.

@devn devn closed this May 10, 2013

Sorry, missed that you hade commented on this PR.
Mainly I would like to be able to specify options, as meta-tags, that don't accept any arguments.
Like --grayscale (https://gist.github.com/magnushoerberg/5553373)

But perhaps a better solution would be to allow pdfkit-meta_tags without the content attribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment