Add a parameter to allow user to skip the pdf generation for error page. #153

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@wushaobo

1) Purpose
Add a parameter to allow user to skip the pdf generation for the response page with error code.

2) Impact
Stick on open-closed principle. All the original behaviour is kept and this new parameter is optional and configurable.

Please email to wushaobo.china@gmail.com if any question to the code, I will be happy to explain it.

@wushaobo

The build for the code in this pull request was red in your CI by odd reason. I configured the CI with my github today and the pull request looks good. Now the status is synchronized and green.

@devn devn commented on the diff May 10, 2013
lib/pdfkit/middleware.rb
@app = app
@options = options
@conditions = conditions
+ @exclude_error = exclude_error
@devn
devn May 10, 2013

Please follow the pattern and align these ivars on =.

@wushaobo
wushaobo May 10, 2013
@sigmavirus24
pdfkit member

This is quite stale and feedback that was left was not addressed. I'm closing this for now, but feel free to open a new pull request @wushaobo that addresses the concerns above and can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment