Check wkhtmltopdf exit status for success, instead of just looking at output #154

Merged
merged 1 commit into from Feb 22, 2013

Conversation

Projects
None yet
5 participants
@swieton
Contributor

swieton commented Nov 16, 2012

This patch updates PDFKit to check the exit status code from wkhtmltopdf. This way, if you expected the page load to be a success and it was not, you can detect it.

devn added a commit that referenced this pull request Feb 22, 2013

Merge pull request #154 from swieton/master
Check wkhtmltopdf exit status for success instead of just checking output

@devn devn merged commit aa0700f into pdfkit:master Feb 22, 2013

1 check passed

default The Travis build passed
Details
@igorkasyanchuk

This comment has been minimized.

Show comment
Hide comment
@igorkasyanchuk

igorkasyanchuk Aug 6, 2013

I've a question about this code change.
I'm faced with issue on production with Passenger 4.0.10 that "!$?.success?" returns false so exception is happen, but PDF is generated. So with commented code "or !$?.success?" everything works well

I've a question about this code change.
I'm faced with issue on production with Passenger 4.0.10 that "!$?.success?" returns false so exception is happen, but PDF is generated. So with commented code "or !$?.success?" everything works well

@golem131

This comment has been minimized.

Show comment
Hide comment

+1

@sigmavirus24

This comment has been minimized.

Show comment
Hide comment
@sigmavirus24

sigmavirus24 Oct 23, 2013

Contributor

@golem131 what are you '+1'ing?

Contributor

sigmavirus24 commented Oct 23, 2013

@golem131 what are you '+1'ing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment