Skip to content


Subversion checkout URL

You can clone with
Download ZIP


Exitstatus #187

wants to merge 2 commits into from

3 participants


This will allow a little bit easier debugging.

@dnagir dnagir referenced this pull request

Allow missing assets #188


Can you close this since you even mentioned in #188 that you incorporated this PR there?


@sigmavirus24 I'm about to comment on the #188 which it looks like we should be able to reject so this may still be "mergable" separately.


The tests fail here so if you're going to close #188 could you fix the tests here?


The tests have been failing for a while on master and Travis. They pass on my OSX though. Looks like something that should be done about Travis.
screen shot 2013-08-15 at 11 53 42 am


@dnagir It looks to me as if the substance of this PR has already been incorporated into master if you look here.

I am closing this PR, but feel free to open a new PR if you still have concerns about the logging.

@cdwort cdwort closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 8, 2013
  1. @dnagir
  2. @dnagir


    dnagir committed
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +1 −1  lib/pdfkit/pdfkit.rb
  2. +1 −1  spec/pdfkit_spec.rb
2  lib/pdfkit/pdfkit.rb
@@ -70,7 +70,7 @@ def to_pdf(path=nil)
result = if path
# $? is thread safe per
- raise "command failed: #{invoke}" if result.to_s.strip.empty? or !$?.success?
+ raise "command failed (exitstatus=#{$?.exitstatus}): #{invoke}" if result.to_s.strip.empty? or !$?.success?
return result
2  spec/pdfkit_spec.rb
@@ -205,7 +205,7 @@
it "should throw an error if it is unable to connect" do
pdfkit ="")
- lambda { pdfkit.to_pdf }.should raise_error
+ lambda { pdfkit.to_pdf }.should raise_error /exitstatus=1/
Something went wrong with that request. Please try again.