GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
shellescape (called inside shelljoin) was designed for Bourne shell, and it mangles Windows paths (e.g. C:\My Install Path\wkhtmltopdf). As per this stackoverflow answer, there is no equivalent of shellescape on Windows platform.
C:\My Install Path\wkhtmltopdf
As an alternative, I've made a simple join/quote-escaping scheme for Windows. I haven't given a detailed look at injection vulnerabilities on Windows. For the time being this will have to be a caveat for Windows users.
Also removed Gemfile.lock. Please see this post from the folks who made Bundler
Do not use shellescape on Windows. Instead use a simple whitespace jo…
…in with a rudimentary quoting scheme.
Specs for Windows shell
Remove Gemfile.lock, which is the recommended practice for gems: http…
Thanks for your efforts here @johnnyshields but a different solution has been used. I'm going to keep the Gemfile.lock for now until I can confirm that it is still best practice to not include it.
@sigmavirus24 it is indeed still the best practice not to include the Gemfile.lock. Look at any widely used gem you will see that they do not include it.
Way ahead of you @johnnyshields (b6e4e80#diff-d41d8cd98f00b204e9800998ecf8427e, d4e7e07#diff-d41d8cd98f00b204e9800998ecf8427e). Thanks for your work here.