Skip to content

Commit e57eaa9

Browse files
committed
fix: Don't silently ignores invalid PDM_BUILD_SCM_VERSION env var . Fixes #268
Signed-off-by: Frost Ming <me@frostming.com>
1 parent e7dbb8e commit e57eaa9

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/pdm/backend/hooks/version/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,10 @@ def resolve_version_from_scm(
9090
fallback_version: str | None = None,
9191
) -> Version:
9292
if os.environ.get("PDM_BUILD_SCM_VERSION"):
93+
source = "environment variable"
9394
version = os.environ["PDM_BUILD_SCM_VERSION"]
9495
else:
96+
source = "scm"
9597
version_formatter: (
9698
Callable[[SCMVersion, Context], str] | Callable[[SCMVersion], str]
9799
)
@@ -106,7 +108,7 @@ def resolve_version_from_scm(
106108
)
107109
if scm_version is None:
108110
if fallback_version is not None:
109-
warnings.warn(_fallback_version_warning.format("scm"), PDMWarning)
111+
warnings.warn(_fallback_version_warning.format(source), PDMWarning)
110112
version = fallback_version
111113
else:
112114
raise ConfigError(
@@ -124,7 +126,7 @@ def resolve_version_from_scm(
124126
parsed_version = Version(version)
125127
except ValueError:
126128
if fallback_version is not None:
127-
warnings.warn(_fallback_version_warning.format("scm"), PDMWarning)
129+
warnings.warn(_fallback_version_warning.format(source), PDMWarning)
128130
return Version(fallback_version)
129131
raise ConfigError(
130132
f"Invalid version {version}, it must comply with PEP 440. \n"

0 commit comments

Comments
 (0)