Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer file url requirements when resolving #800

Merged
merged 3 commits into from Dec 16, 2021
Merged

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Dec 16, 2021

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Close #799

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021

Codecov Report

Merging #800 (f1950c1) into main (911a414) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
+ Coverage   83.41%   83.42%   +0.01%     
==========================================
  Files          73       73              
  Lines        6203     6208       +5     
  Branches     1117     1119       +2     
==========================================
+ Hits         5174     5179       +5     
  Misses        735      735              
  Partials      294      294              
Flag Coverage Δ
unittests 83.21% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/project/config.py 96.11% <ø> (ø)
pdm/resolver/providers.py 96.00% <100.00%> (ø)
pdm/resolver/reporters.py 97.72% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a84e8bc...f1950c1. Read the comment docs.

@frostming frostming merged commit 6390478 into main Dec 16, 2021
@frostming frostming deleted the fix/resolve-file-url branch December 16, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing from allow_prereleases = true to allow_prereleases = false slows down install to a crawl
2 participants