Make closing stdin optional?

[nicolaskruchten]

For the module I'm working on, this defensive line is actually breaking things because a dependency of a dependency is checking if stdin is open: https://github.com/pdoc3/pdoc/blob/master/pdoc/cli.py#L285

Would it be possible to allow this behaviour to be turned off via a flag or environment variable? If you'd accept such a PR I'd be happy to contribute it :)

[kernc]

I'm not entirely sure why it was introduced in the first place; I'd likely prefer to consider modules messing with stdin outside their __name__ == '__main__' block wholly misbehaved.

I think it would be acceptable to make the default remain open and only close it upon --close-stdin.

[nicolaskruchten]

I agree that these modules are misbehaving, but I can't really control dependencies of dependencies :) I'll try to get a PR in today, leaving the current behaviour on by default but allowing for it to be disabled.

[kernc]

I'm happy with inverting the default. We've made some best-effort incompatibility changes recently, so this won't strike anyone as odd. Times were different when this was introduced. 😄