Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-Module Link Error Only on Windows #41

Closed
KyleKing opened this issue Mar 2, 2019 · 0 comments
Closed

Sub-Module Link Error Only on Windows #41

KyleKing opened this issue Mar 2, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@KyleKing
Copy link
Contributor

KyleKing commented Mar 2, 2019

Issue

The Sub-Modules links on the left sidebar should link to the file; however, on Windows the links are incorrect. On Windows, the path has an incorrect relative (../), which isn't present on Mac (I don't have Linux to check, but probably only an issue on Windows).

On Windows:

linkissue

Links to http://localhost:8080/diagnose.html (..\diagnose.html)

badlink

When it should link to http://localhost:8080/bs4/diagnose.html (./diagnose.html)

On Mac

Works as expected:

MacInspect

Steps to Reproduce

# # Setup
# git clone ...
# pip install -e .
# pip install beautifulsoup4

# Demo
pdoc bs4 --http :
# or: pdoc bs4 --html

Additional info

  • pdoc version: latest as of 01Mar2019: 1e0608f
  • OS: (Windows 7, Mac OS Mojave)

I'm planning on working on a PR/bug fix for this, but wanted to document what I'm seeing first

@kernc kernc added the bug Something isn't working label Mar 3, 2019
@kernc kernc closed this as completed in #42 Mar 3, 2019
@kernc kernc added the good first issue Good for newcomers label Mar 3, 2019
@kernc kernc modified the milestone: 0.5.3 Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Development

No branches or pull requests

2 participants