Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upmove main docstring into a file #57
Conversation
kernc
approved these changes
May 1, 2019
pdoc/__init__.py Outdated
kernc
reviewed
May 1, 2019
pdoc/documentation.md Outdated
This comment has been minimized.
This comment has been minimized.
|
I want to run the markdown autoformatter on this file to make it more consistent, but I can't tell what format its contents are. Is it markdown? Markdown with some pdoc syntax mixed in? Rst? |
kernc
reviewed
May 1, 2019
pdoc/documentation.md Outdated
cs01
and others
added some commits
May 1, 2019
This comment has been minimized.
This comment has been minimized.
|
I'm sorry for not having been more verbose up front. Let's just do the moving in this PR (which will become a commit) and the TBD reflowing in a subsequent PR. I'm sure you can see the advantage of this (large, strictly moving remaining a stand-alone commit). |
kernc
merged commit eda27f3
into
pdoc3:master
May 1, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
What do you mean? It's actually simple Markdown Extra. Really just what is supported by Python Markdown with enabled plugins. Lines 67 to 77 in eda27f3 |
This comment has been minimized.
This comment has been minimized.
And some reST directives, which are in the pipeline transformed into markdown admonitions. |
This comment has been minimized.
This comment has been minimized.
|
Btw, thanks for this! Indeed, both files are much more manageable now! |
kernc
added a commit
that referenced
this pull request
May 1, 2019
This comment has been minimized.
This comment has been minimized.
|
Ah sorry about that "revert typo" commit. What happened there was I am using VS Code and they have an auto-formatter for markdown files which I forgot I ran. I was asking earlier about the language of the docstring, because when I ran the VS Code autoformatter it was stripping away what looked like useful information. I see now that is because pdoc is using various syntax that the autoformatter doesn't recognize.
Consistent heading syntax, for example. i.e.
is transformed to
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Nice, thanks for the release! |
cs01 commentedMay 1, 2019
This makes the code easier to read since it's not underneath a large docstring. It also makes the documentation easier to edit since text editors can add syntax highlighting to the raw markdown content, and do realtime markdown previews.