New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Custom Attributes #106

Closed
hadi77ir opened this Issue Nov 20, 2017 · 1 comment

Comments

2 participants
@hadi77ir
Copy link

hadi77ir commented Nov 20, 2017

There is no custom attribute on classes, properties, variables, etc. in PHP.
Would it get implemented in Peachpie in future (useful for both-way .NET interop)?

@jakubmisek

This comment was marked as outdated.

Copy link
Member

jakubmisek commented Nov 20, 2017

This will be achieved in a backward compatible way - through PHPDoc comments. Such code will be still a valid PHP code.

We already support our custom attribute @appstatic (https://www.peachpie.io/2017/11/caching-across-requests-php.html)

In general, to support .NET attributes in future, we may support something like:

/**
 * @[CustomAttribute(A, B, C)]
 */

@jakubmisek jakubmisek closed this Nov 20, 2017

@jakubmisek jakubmisek reopened this Nov 20, 2017

@jakubmisek jakubmisek changed the title No Custom Attributes Support for Custom Attributes Nov 20, 2017

@jakubmisek jakubmisek added this to todo in .NET interop via automation Nov 22, 2017

jakubmisek added a commit that referenced this issue Nov 11, 2018

jakubmisek added a commit that referenced this issue Nov 11, 2018

@jakubmisek jakubmisek added this to To do in AWS Lambda via automation Nov 11, 2018

jakubmisek added a commit that referenced this issue Nov 12, 2018

.NET interop automation moved this from TODO to done Nov 12, 2018

AWS Lambda automation moved this from To do to Done Nov 12, 2018

jakubmisek added a commit that referenced this issue Nov 12, 2018

jakubmisek added a commit that referenced this issue Nov 12, 2018

parsing custom attributes perf
- related to #106
- not parsing when not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment