Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded by-reference on built-in fuction #18

Merged
merged 1 commit into from Jun 11, 2017

Conversation

@andytson
Copy link
Contributor

commented Jun 11, 2017

PHP 7.2 is complaining about this. It also doesn't appear to be
needed, as the argument array items aren't being passed by-reference.

Remove unneeded by-reference on built-in fuction
PHP 7.2 is complaining about this. It also doesn't appear to be
needed, as the argument array items aren't being passed by-reference.
@rainerjung

This comment has been minimized.

Copy link

commented Jun 11, 2017

I ran into the same problem. PGP 7.2.0alpha1 installation fails when it tries to create pear due to this bug. The failure comes from a new check in the zend engine that returns the error "Cannot use result of built-in function in write context".

It would be nice if you could apply the patch and roll a release, which could then be used in PHP 7.2.

@rainerjung

This comment has been minimized.

Copy link

commented Jun 11, 2017

@mrook mrook merged commit 772f7d0 into pear:master Jun 11, 2017

@andytson andytson deleted the andytson:feature/php-7.2-fixes branch Jun 11, 2017

@mrook

This comment has been minimized.

Copy link
Member

commented Jun 11, 2017

1.4.3 has been rolled & pushed, thanks!

@tvlooy

This comment has been minimized.

Copy link

commented Jun 23, 2017

I got bitten by this one too. After some debugging I found out Andy beat me to the fix by 12 days :-)

The install-pear-nozlib.phar and go-pear.phar need to be rebuild with this version. Who can do that @mrook ?

@rainerjung

This comment has been minimized.

Copy link

commented Jun 24, 2017

For the *.phar update see

pear/pearweb_phars#2

I guess that's the upstream.

@tvlooy

This comment has been minimized.

Copy link

commented Jun 24, 2017

@rainerjung thanks for pointing me in the right direction 👍

@mrook

This comment has been minimized.

Copy link
Member

commented Jun 25, 2017

I think @ashnazg can roll a new phar.

@brunoric brunoric referenced this pull request Jun 25, 2017
@ashnazg

This comment has been minimized.

Copy link
Member

commented Jun 25, 2017

Yep, already have this on my list... in office tomorrow.

@wafa363

This comment has been minimized.

Copy link

commented Feb 21, 2018

I'm having a problem , can anyone tell me how to deal with it ?
capture

@mrook

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

@wafa363 what version of PHP, PEAR and Archive_Tar are you running?

@wafa363

This comment has been minimized.

Copy link

commented Feb 21, 2018

@mrook I'm running PHP version 7.2.1 , PEAR Version: 1.10.1 and I'm not sure about the pear Archive_Tar I couldn't know anything about it's version

@mrook

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

What does pear list show? You're probably best off by re-installing the latest PEAR, that should pull in Archive_Tar 1.4.3 (which includes this fix).

@wafa363

This comment has been minimized.

Copy link

commented Feb 21, 2018

it shows this
capture

@wafa363

This comment has been minimized.

Copy link

commented Feb 21, 2018

So I have to re-install the latest PEAR because it includes Archive_Tar 1.4.3 that have the fix for my problem

@mrook

This comment has been minimized.

Copy link
Member

commented Feb 21, 2018

Yes, Archive_Tar 1.4.0 is not compatible with PHP 7.2. Thanks!

@wafa363

This comment has been minimized.

Copy link

commented Feb 21, 2018

@mrook Thanks , it worked 💯 you've been very helpful 👍

@EdixonAlberto

This comment has been minimized.

Copy link

commented Jul 24, 2019

I have Archive_Tar 1.4.7 and php 7.3.4 and all the same error occurred to me that @wafa363. I already solved the problem, but I would like to know if there is an issue about it?

@mrook

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

@EdixonAlberto can you explain what you're missing?

@EdixonAlberto

This comment has been minimized.

Copy link

commented Jul 24, 2019

Already solved: You have to go to the line indicated in the error (639 in this case) and replace:

$v_att_list = & func_get_args();

with

$v_att_list = func_get_args();

This means that func_get_args() is no longer called by reference.

@mrook

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Yes, that is exactly what was changed in this pull request (and is part of Archive_Tar 1.4.3 and up).

@EdixonAlberto

This comment has been minimized.

Copy link

commented Jul 24, 2019

Well, I have the latest version and I had to modify the file.
Image 006

@mrook

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

I can't reproduce that. When I download, extract & inspect http://download.pear.php.net/package/Archive_Tar-1.4.7.tgz, the file is as it should be. Can you clear your cache(s) & reinstall?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.