Skip to content
Browse files

Merge pull request #1 from robmeek/patch-1

Fix typo to allow use of stream parameter type
  • Loading branch information...
2 parents 359a503 + 9c0bace commit a0f4545a62a666e90189699a7fac3a291145506a @CloCkWeRX CloCkWeRX committed Jan 13, 2013
Showing with 2 additions and 2 deletions.
  1. +2 −2 CodeGen/PECL/Element/Function.php
View
4 CodeGen/PECL/Element/Function.php
@@ -1193,8 +1193,8 @@ function cCode($extension)
$zvalType = true;
$argString .= "r";
$var_decl .= " zval * {$name}_zval = NULL;\n";
- $var_decl .= " php_stream * $name = NULL:\n";
- $postProcess .= " php_stream_from_zval($name, &_z$name);\n";
+ $var_decl .= " php_stream * $name = NULL;\n";
+ $postProcess .= " php_stream_from_zval($name, &{$name}_zval);\n";
break;
case "callback":

5 comments on commit a0f4545

@nickl-
nickl- commented on a0f4545 Jan 13, 2013

@CloCkWeRX are you giving this attention again? Awesome! I have a pull request for you as well. Let me rebase quick...

Please confirm, is this the latest version of the source including the extension.dtd?

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

As far as I know, yes, it's the latest.

@nickl-
nickl- commented on a0f4545 Jan 13, 2013

@CloCkWeRX Do you mind enabling issues for local discussions, or do you prefer using php bug tracker instead?

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

This package is unmaintained, which is a bit of why it's hard to get attention on it.

What sort of fixes or changes do you see for it in the near future? I'm fairly sure we'd be happy to just give you the required access to do those changes if we understood them. For generally discussion, perhaps the pear-dev mailing list might be a start.

@nickl-
nickl- commented on a0f4545 Jan 13, 2013

@CloCkWeRX Currently I am still focusing on maintenance, sorting out all the hiccups and incomplete/broken bits, and haven't given the future much thought yet.

I would imagine that all the Zend changes applied to 5.4.x would have to be worked in haven't looked at what happens to 5.4/5.5 yet.
Having a "maintained" project would go a long way to get buy in from the community.

I already have lots on my plate but why not, whats one more going to do =) chances that I get around to pear-dev and other bug trackers are dim, I'm here daily and would then spot things happening which I can attend to. So if you want me to take the ropes I will be glad to oblige. Do you have any clue where the repository for CodeGen has gone? Ideally we need to get access to that as well to get everything up to speed.

I thought we weren't going to be hearing from you (not maintained and all) so I just merged the pull request on my repo but was in no hurry to push everything. Let me get that sorted quick so that we can at least get the basics down.

Please sign in to comment.
Something went wrong with that request. Please try again.