Misc QA fixes for review #1

Merged
merged 4 commits into from Nov 6, 2011

3 participants

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

So; with Jenkins now available - how do we feel about phpunit 3.6, a build.xml (implying ant), dropping AllTests, etc?

@till
PEAR - PHP Extension and Application Repository member

I don't mind either. Maybe we can pre-process this before the job runs?

Pull request looks good: +1

@cweiske
PEAR - PHP Extension and Application Repository member

I'd rather use phing than ant, but I'm ok with dropping alltests (as long as we have something that pear can use with run-tests )

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

@till - when you say preprocess; what do you mean?
@cweiske - pear run-tests supports phpunit AllTests out of the box? Or at least can be told "pear run-tests tests/AllTests.php" and have it treat it like a normal PHP file? What does it do with the results?

@CloCkWeRX CloCkWeRX merged commit 6c339be into pear:master Nov 6, 2011
@till
PEAR - PHP Extension and Application Repository member

@ClockWerx: I mean, I wouldn't go through all packages and delete AllTests.php now. I'd tell people it's not necessary anymore so new packages don't do it or current packages can update when they get around to it.

Also, I'd probably try to leverage a phpunit.xml (somehow) because it makes bootstrapping tests with phpunit very simple.

Generally, I'm not sure how jenkins is being setup, but maybe that part would just do whatever is necessary to run tests.

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

@till - I agree - I've been doing two main types of jobs.

  1. phpunit --with-lots -of flags tests/[AllTests.php if needed]
  2. build.xml + phpunit.xml when there are external libraries; and the jenkins build has ~3+ custom commands to manage it.
@cweiske
PEAR - PHP Extension and Application Repository member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment