Misc QA fixes for review

[CloCkWeRX]

So; with Jenkins now available - how do we feel about phpunit 3.6, a build.xml (implying ant), dropping AllTests, etc?

[till]

I don't mind either. Maybe we can pre-process this before the job runs?

Pull request looks good: +1

[cweiske]

I'd rather use phing than ant, but I'm ok with dropping alltests (as long as we have something that pear can use with run-tests )

[CloCkWeRX]

@till - when you say preprocess; what do you mean?
@cweiske - pear run-tests supports phpunit AllTests out of the box? Or at least can be told "pear run-tests tests/AllTests.php" and have it treat it like a normal PHP file? What does it do with the results?

[till]

@CloCkWeRX: I mean, I wouldn't go through all packages and delete AllTests.php now. I'd tell people it's not necessary anymore so new packages don't do it or current packages can update when they get around to it.

Also, I'd probably try to leverage a phpunit.xml (somehow) because it makes bootstrapping tests with phpunit very simple.

Generally, I'm not sure how jenkins is being setup, but maybe that part would just do whatever is necessary to run tests.

[CloCkWeRX]

@till - I agree - I've been doing two main types of jobs.

1. phpunit --with-lots -of flags tests/[AllTests.php if needed]
2. build.xml + phpunit.xml when there are external libraries; and the jenkins build has ~3+ custom commands to manage it.

[cweiske]

Hello Daniel,

@till - when you say preprocess; what do you mean?
@cweiske - pear run-tests supports phpunit AllTests out of the box?
Or at least can be told "pear run-tests tests/AllTests.php" and have
it treat it like a normal PHP file? What does it do with the results?

See http://pear.php.net/bugs/bug.php?id=10834
and http://pear.php.net/bugs/bug.php?id=11883
which implemented phpunit alltests support

Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-