Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding 3 characters ISO3166 code to Spain driver #1

Merged
merged 1 commit into from Feb 23, 2014

Conversation

Projects
None yet
4 participants
Contributor

jespino commented Dec 19, 2013

No description provided.

Contributor

jespino commented Dec 19, 2013

And I generate a new versión with this, after the merge i will publish a new release.

Owner

till commented Feb 20, 2014

@jespino Should I merge this for you? Btw, there's also #2. Can you merge that?

Contributor

jespino commented Feb 20, 2014

Of course, I haven't permissions to do it by myself 😞

You can merge the #2 too.

CloCkWeRX added a commit that referenced this pull request Feb 23, 2014

Merge pull request #1 from jespino/smallfix
Adding 3 characters ISO3166 code to Spain driver

@CloCkWeRX CloCkWeRX merged commit 58be6ca into pear:trunk Feb 23, 2014

Owner

CloCkWeRX commented Feb 23, 2014

@jespino @kenguest - what do you want to do about this long term? I remember it being a pain in the behind to split up the validate_* packages; any objections to just granting all of the contributors access to the repo?

Owner

kenguest commented Feb 26, 2014

I've added @jespino to the pear-dev team - I'm not entirely sure, but I think that's all that needs to be done to give him access?

Owner

kenguest commented Feb 26, 2014

@CloCkWeRX To answer your question I don't mind giving lead developers access to the repo as I'd presume they know what they're doing; not entirely sure about giving helpers and casual contributors access though.

Owner

till commented Feb 26, 2014

@CloCkWeRX @kenguest Create a validate team and let people drive it.

Owner

kenguest commented Feb 28, 2014

@till: I know you meant a date_holidays team, not a validate one ;) I've set one up and added @jespino to it to begin with. We can always add others when/if they request to be added to it.

Owner

till commented Feb 28, 2014

@kenguest Sorry, I meant a Date team.

Owner

CloCkWeRX commented Mar 1, 2014

https://github.com/orgs/pear/teams/date exists.
I can add:

  • Carsten Lucke (Ukraine, others)
  • Serkan Cetintopcu (Turkey)
  • Boban Acimovic (Serbia)
    if you want.

@till, seperate observation - there's a bunch of package_foo.xml's; but 1x composer.json.

Owner

till commented Mar 1, 2014

@CloCkWeRX 👍 on adding them.

On the json-files: You can't have multiple. I mean, you can but there is no mechanism to list files in them or crawl multiple composer.json files in a single repository. Are you referring to Date_Holidays or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment