Skip to content

hash table support #1

Closed
wants to merge 1 commit into from

2 participants

@Elbandi
Elbandi commented Jan 2, 2012

This is the patch for this feature request:
https://pear.php.net/bugs/bug.php?id=18562

Elbandi

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

Thanks! I'd missed this pull request, sorry for the delay.

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

Can you fix the signature to be _is_prime($candiate) with no space?
Also, any chance of docblocks?

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

Can you avoid inline control structures? (add braces)

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

As above re inline structures

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

Inline structures again

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

Hmm odd: "Your merge target has changed since we cached the merge commit - try the merge again"

@CloCkWeRX CloCkWeRX closed this Jan 28, 2012
@CloCkWeRX
PEAR - PHP Extension and Application Repository member

I cherry picked all of your commits, so this is now closeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.