Skip to content

Conversation

@duboism
Copy link
Contributor

@duboism duboism commented Dec 24, 2024

This PR declares property blockparents in class HTML_Template_IT.

The property was used but not declared (this was discovered while working on #16). So called dynamic properties are deprecated since PHP 8.2. I suggest to merge this after #18.

@duboism
Copy link
Contributor Author

duboism commented Dec 29, 2024

I just realized I can now merge PR so let's go :)

@duboism duboism merged commit 378606f into pear:master Dec 29, 2024
20 checks passed
@duboism duboism deleted the undeclared_property branch December 29, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant