Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added new request event and Hawk observer #5

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Member

golgote commented Mar 1, 2014

Not tested, just for review.

golgote added some commits Mar 1, 2014

Add the request event
Before the request is made
Adds the Hawk observer
Hawk is an authentication protocol, like Digest but with less roundtrips
Member

sad-spirit commented Apr 12, 2014

Hi, Bertrand, sorry for a delayed response.

I see a couple of problems with that 'request' event right now. The first one is easy, it should fire before connecting in Socket adapter (the observer may want to change connection options).

The second is more tricky: the event will fire when handling a redirect with Socket adapter and will not fire when handling a redirect with Curl adapter, it probably should be both or neither. On the other hand, 'request' event for a redirect in Curl adapter doesn't help much since redirects are processed by curl itself and little can be done to change request at this point.

Maybe the event should be fired inside HTTP_Request2 class itself, right before calling Adapter::sendRequest()?

Owner

CloCkWeRX commented Mar 22, 2015

Closing due to lack of activity since feedback was given.

@CloCkWeRX CloCkWeRX closed this Mar 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment