some fixes #1

Merged
merged 3 commits into from Dec 11, 2011

2 participants

@Gemorroj
PEAR - PHP Extension and Application Repository member

Hello. Corrections for Image_Barcode2.

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

We should swap from PEAR::raiseError to exception at some point.

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

We should do this with an interface.

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

I know it's just leftover from the old package, but could we ditch the spaces around the ( )'s ?
(TODO: Run php code sniffer across this package).

PEAR - PHP Extension and Application Repository member

Of course!

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

So... with these, was it ever possible to pass in params? If so, how do people using the package need to update their code to make it render with/without text and to a height?

PEAR - PHP Extension and Application Repository member

I do understand why there such a realization. Barcode must be given through a file Barcode.php where there is no transfer of these parameters.

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

Could we make setters/getters. or protected for these? (I take it that private was too restrictive in some way)

PEAR - PHP Extension and Application Repository member

Yes, I'm just too lazy to do it yet.

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

Ditto setters/getters for these

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

TODO - work out why it needs to extend PEAR

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

Swapping to Exceptions should make this a non issue. TODO: Image_Barcode2_Exception

@CloCkWeRX
PEAR - PHP Extension and Application Repository member

TODO: class foo implements Image_Barcode2_Driver

@CloCkWeRX CloCkWeRX merged commit 349ad19 into pear:master Dec 11, 2011
@CloCkWeRX
PEAR - PHP Extension and Application Repository member

So; I've raised issue #2 issue #3 issue #4 issue #5 and issue #6 for some of the misc tasks, and will be focused on issue #2 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment