PostNet, and PHPCS fixes #12

Merged
merged 6 commits into from Mar 5, 2012

Conversation

Projects
None yet
2 participants
Member

Gemorroj commented Mar 5, 2012

Fixed display PostNet.
Updated examples.
PHPCS ( issue #3 )

throw new Image_Barcode2_Exception($type . ' barcode is not supported');
}
- $classname = 'Image_Barcode2_' . $type;
@CloCkWeRX

CloCkWeRX Mar 5, 2012

Owner

With these, I shied away from ucfirst. In other packages, it leads to people doing stupid non camel cased class names - ie "Foobar".

It's a pity Text_Inflector never made it into PEAR :(

I can't decide if the restriction should be relaxed - just trust the user input to be right, and raise exceptions if a class doesn't exist - or enforced.

- * @author Ryan Briones <ryanbriones@webxdesign.org>
- *
- *
+ * @return string $result barcode line code
@CloCkWeRX

CloCkWeRX Mar 5, 2012

Owner

Can you run phpcs over it? You've fixed a lot of the issues, but string $result should probably only have 1-2 spaces

Owner

CloCkWeRX commented Mar 5, 2012

Looks good to me. You've done a few of these with consistent quality - I might just grant you karma to the core package itself

CloCkWeRX added a commit that referenced this pull request Mar 5, 2012

Merge pull request #12 from Gemorroj/master
PostNet, and PHPCS fixes

@CloCkWeRX CloCkWeRX merged commit 13b1e0e into pear:master Mar 5, 2012

Owner

CloCkWeRX commented Mar 5, 2012

Granted repo access - got a PEAR username? I'll add you as a maintainer.

Member

Gemorroj commented Mar 6, 2012

Thanks. my PEAR profile http://pear.php.net/user/gemorroj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment