GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fixed display PostNet.
PHPCS ( issue #3 )
#3 Intermediate commit
#3 rename files
fixed UPC-A and PostNet barcode validators
added EAN-8 example, fixed barcodes in examples.
fixed PostNet barcodes
fixed UPC-A example
With these, I shied away from ucfirst. In other packages, it leads to people doing stupid non camel cased class names - ie "Foobar".
It's a pity Text_Inflector never made it into PEAR :(
I can't decide if the restriction should be relaxed - just trust the user input to be right, and raise exceptions if a class doesn't exist - or enforced.
Can you run phpcs over it? You've fixed a lot of the issues, but string $result should probably only have 1-2 spaces
Looks good to me. You've done a few of these with consistent quality - I might just grant you karma to the core package itself
Merge pull request #12 from Gemorroj/master
PostNet, and PHPCS fixes
Granted repo access - got a PEAR username? I'll add you as a maintainer.
Thanks. my PEAR profile http://pear.php.net/user/gemorroj