Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #20938: GPG signing and encryption #9

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@cweiske
Copy link
Member

cweiske commented Oct 20, 2015

What do you think?

@cweiske

This comment has been minimized.

Copy link
Member Author

cweiske commented Jun 16, 2016

@alecpl: What do you think about this patch?

@alecpl

This comment has been minimized.

Copy link
Contributor

alecpl commented Jun 16, 2016

@cweiske, I was going to review it, but in general I'm not sure this is a good idea. Roundcube already implemented this as a wrapper on Mail_mime. See https://github.com/roundcube/roundcubemail/blob/master/plugins/enigma/lib/enigma_mime_message.php. I'm not saying it's better or complete. I just am not sure encryption should be a part of Mail_mime.

@cweiske

This comment has been minimized.

Copy link
Member Author

cweiske commented Jun 16, 2016

Moving this to a standalone class that extends Mail_Mime would be nice. I'm just not sure if Mail_mime is made for this.

@alecpl

This comment has been minimized.

Copy link
Contributor

alecpl commented Jun 16, 2016

enigma_mime_message already extends Mail_mime, so it's not impossible.

I reviewed your changes. Two main issues:

  1. It does not support encryption when saving mail to a file, so is not complete.
  2. Crypt_GPG throws exceptions, but Mail_mime does not. I don't know what is a common way of handling such situation in PEAR world.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.