Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement #20938: GPG signing and encryption #9
@cweiske, I was going to review it, but in general I'm not sure this is a good idea. Roundcube already implemented this as a wrapper on Mail_mime. See https://github.com/roundcube/roundcubemail/blob/master/plugins/enigma/lib/enigma_mime_message.php. I'm not saying it's better or complete. I just am not sure encryption should be a part of Mail_mime.
enigma_mime_message already extends Mail_mime, so it's not impossible.
I reviewed your changes. Two main issues: