Remove E_STRICT errors #1

Merged
merged 24 commits into from Jun 6, 2012

2 participants

@grahamc

Net_IMAP is unusable for me without these changes.

Replace all PEAR::isError calls with an instanceOf PEAR_Error.

Also improves the state of the unit tests slightly, but I never could get them to run properly - I think most notably due to my only IMAP servers being GMail ones which restrict your activity.

@convissor
PEAR - PHP Extension and Application Repository member

The overall direction is great. I'll be glad to merge the pull request once the two adjustments are incorporated.

@grahamc

Alright, I've replaced the Autoload.php and removed the sorting on the unit test, however I kept the check on $this->fixture since removing it causes fatal errors.

@convissor convissor and 1 other commented on an outdated diff Jun 6, 2012
Net/IMAP.php
@@ -16,7 +17,7 @@
/**
* IMAPProtocol.php holds protocol implementation for IMAP.php
*/
-require_once 'Net/IMAPProtocol.php';
+require_once __DIR__ . '/IMAPProtocol.php';
@convissor
PEAR - PHP Extension and Application Repository member

DIR was added in 5.3. Need to use dirname(FILE).

@convissor
PEAR - PHP Extension and Application Repository member

Uh, but you shouldn't be hard coding includes here at all.

@grahamc
grahamc added a note Jun 6, 2012

So remove this entire line? When it was Net/IMAPProtocol it was impossible to run tests against it.

@convissor
PEAR - PHP Extension and Application Repository member

To clarify, leave it with the path unspecified. Let include path do it's thing.

@grahamc
grahamc added a note Jun 6, 2012

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@convissor convissor merged commit 1caddb7 into pear:master Jun 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment