Net_IMAP is unusable for me without these changes.
Replace all PEAR::isError calls with an instanceOf PEAR_Error.
Also improves the state of the unit tests slightly, but I never could get them to run properly - I think most notably due to my only IMAP servers being GMail ones which restrict your activity.
Fixing whitespace issues
Resolve a Pear::iserror issue; translate the text
Don't require PHPUnit, since that is a deprecated behavior
Set the reservedFolders to an empty array by default, resolving a not…
Moving the setup to the top of the test file
Incremental pear::isError commit
FIxing isError references
Remove simple PEAR_Error checks
Removing isError nonsense
Removing PEAR_Error bits
Using PHPUnit/Autoload.php on unit tests.
The overall direction is great. I'll be glad to merge the pull request once the two adjustments are incorporated.
Revert 68a033e8aedb1c4b508061a1d0e6ba8ddab00670 to reduce churn, per @…
Wrap the teardown to prevent fatal errors when the fixture is not set.
Alright, I've replaced the Autoload.php and removed the sorting on the unit test, however I kept the check on $this->fixture since removing it causes fatal errors.
DIR was added in 5.3. Need to use dirname(FILE).
Uh, but you shouldn't be hard coding includes here at all.
So remove this entire line? When it was Net/IMAPProtocol it was impossible to run tests against it.
To clarify, leave it with the path unspecified. Let include path do it's thing.
Remove the directory const in favor of include_path