Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

First attempt at converting to a PHP 5 package #4

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

slusarz commented Feb 18, 2013

Convert to PHP 5 OO style.
Errors are now reported via PEAR_Exceptions.
Removed deprecated commands/parameters.
Gets rid of strict errors when running with PHP 5.4+

slusarz commented Feb 18, 2013

Pretty sure this sort of upgrade is going to require a Net_SMTP2 (or similar) release. But this will hopefully be a good starting point.

probably need to convert Net_Socket also for the same reasons. These are the only 2 PEAR packages left at the moment used by Horde/IMP that are throwing strict warnings.

First attempt at converting to a PHP 5 package
Convert to PHP 5 OO style.
Errors are now reported via PEAR_Exceptions.
Removed deprecated commands/parameters.
Owner

till commented Feb 21, 2014

@slusarz Are you still on this, or do you want to update this PR?

slusarz commented Feb 24, 2014

Long ago wrote a new SMTP client library to address all the performance issues/PHP 5 improvements in the original pull request (https://github.com/horde/horde/tree/master/framework/Smtp).

I assume the PR is still ok, but I haven't used/tested the code since the initial request. So do with this PR what you want.

CloCkWeRX added a commit that referenced this pull request Mar 9, 2014

CloCkWeRX added a commit that referenced this pull request Mar 9, 2014

CloCkWeRX added a commit that referenced this pull request Mar 9, 2014

@CloCkWeRX CloCkWeRX closed this in 558b92f Mar 9, 2014

CloCkWeRX added a commit that referenced this pull request Sep 4, 2014

Revert "Fix #4"
This reverts commit 558b92f.

CloCkWeRX added a commit that referenced this pull request Sep 4, 2014

Revert "Apply more of #4"
This reverts commit 00e00af.

CloCkWeRX added a commit that referenced this pull request Sep 4, 2014

Revert "Apply more of #4"
This reverts commit dc713a3.

CloCkWeRX added a commit that referenced this pull request Sep 4, 2014

Revert "Apply #4 partially"
This reverts commit 7273bec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment