Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added support for XML "nillable" when using SOAP overload extension #1

Merged
merged 3 commits into from Aug 27, 2012

Conversation

Projects
None yet
3 participants
Contributor

evictor commented Aug 9, 2012

Mainly this means that the eval'd class method signatures have arguments with default values of NULL as defined by the WSDL so you can call a method like $Client->[method name]([arg1], [arg2] = NULL) and omit arg2.

Currently this is not possible; if your WSDL specifies an arg to a method as nillable or minCount = 0, the generated PHP method signature code by SOAP_WSDL is such that you must provide all arguments to the method when calling it via overload extension. Also, if you pass NULL for an argument, it will still show up as empty in the generated request XML when really the nillable argument should be omitted entirely (and is with this patch if you leave the argument as NULL).

@evictor evictor Added support for XML "nillable" when using SOAP overload extension. …
…Mainly this means that the eval'd class method signatures have arguments with default values of NULL as defined by the WSDL so you can call a method like $Client->[method name]([arg1], [arg2] = NULL) and omit arg2.
c3ae947

Indentation and coding style - can you match the existing code here?

Ditto here

@evictor evictor - Converted indentation tabs => spaces to match existing style.
- Changed some var names, capitalization, brace position to match existing style.
2a48dd5
Owner

evictor commented on c3ae947 Aug 13, 2012

OK, see next commit 2a48dd5.

Owner

CloCkWeRX commented Aug 13, 2012

Sorry to nitpick, but you missed the if statement style slightly.
If( vs if (

@ghost ghost assigned yunosh Aug 13, 2012

That covers, the indentiation, but I meant "if(" vs "if ("

Owner

evictor replied Aug 27, 2012

Yes, check out commit d826f68 -- I also fixed the if style.

@CloCkWeRX CloCkWeRX added a commit that referenced this pull request Aug 27, 2012

@CloCkWeRX CloCkWeRX Merge pull request #1 from evictor/trunk
Added support for XML "nillable" when using SOAP overload extension
c20e077

@CloCkWeRX CloCkWeRX merged commit c20e077 into pear:trunk Aug 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment