Permalink
Switch branches/tags
Nothing to show
Commits on Jan 30, 2012
Commits on Jan 29, 2012
  1. rm test

    hm2k committed Jan 29, 2012
Commits on Jan 28, 2012
  1. updated example to use Exception

    hm2k committed Jan 28, 2012
Commits on Jan 27, 2012
  1. list name can be empty

    hm2k committed Jan 27, 2012
  2. rm leading space in README.md

    hm2k committed Jan 27, 2012
  3. minor tweaks

    hm2k committed Jan 27, 2012
  4. new set of tests for members() function in various states; improved t…

    …est_lists for the lists() function
    hm2k committed Jan 27, 2012
  5. added Exception file to package.xml

    hm2k committed Jan 27, 2012
  6. $request is now public to allow mock adapter; better errors; migrated…

    … members() function to xml; cleanup
    hm2k committed Jan 27, 2012
  7. rm error output

    hm2k committed Jan 27, 2012
  8. added html used for testing

    hm2k committed Jan 27, 2012
Commits on Jan 26, 2012
  1. Fixed @version issue

    hm2k committed Jan 26, 2012
  2. Line indented incorrectly

    hm2k committed Jan 26, 2012
  3. 89 | ERROR | The variable names for parameters $adminPW (3) and $req…

    …uest | | (4) do not align
    hm2k committed Jan 26, 2012
Commits on Jan 25, 2012
  1. Merge pull request #7 from till/patch-1

    Fixed some cs for you and showed you how to simplify some if/else/elseif...
    hm2k committed Jan 25, 2012
  2. Fixed some cs for you and showed you how to simplify some if/else/els…

    …eif constructs. Please run PHP_CodeSniffer (aka phpcs) as others have suggested.
    
    
    I simplified your your setRequest() method heavily, take a look – less code. And it works.
    
    I don't know why you didn't create a "Services_Mailman_Exception" class to make catching exceptions from your package easier. That would be especially useful if your code is used within other code. It's as simple as "class Services_Mailman_Exception extends Exception {}" in a new Exception file.
    
    Reading your code with all the regexp, etc. – my opinion is that it's just bound to break sooner or later. A DOM-based selector would be a lot better. I'm not sure why you insist to use regexp. Your array_merge(), array_pop(), etc. is pretty unreadable. I just hope I never have to hunt a bug in this package. That's also a reason why I'd appreciate something DOM-based.
    till committed Jan 25, 2012
Commits on Jan 24, 2012
  1. Improved comments for phpdoc; added better error checking; methods re…

    …turning true can now be chained
    hm2k committed Jan 24, 2012
Commits on Jan 21, 2012
  1. up php version

    hm2k committed Jan 21, 2012
  2. Using webdev toolbar to confirm the form from POST to GET I was able …

    …to get the correct URL string and make amendments
    hm2k committed Jan 21, 2012
  3. Oops too, fixed adminpw in URLs

    hm2k committed Jan 21, 2012
  4. Oops! Fix as per #6.

    hm2k committed Jan 21, 2012
Commits on Jan 20, 2012
  1. As per Olle Jonsson's suggestions: "object" is a valid PHP type, but …

    …HTTP_Request2 is much more specific.
    hm2k committed Jan 20, 2012
  2. improved some of the comments

    hm2k committed Jan 20, 2012