Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 19464: Add Command class and refactor code #4

Merged
merged 16 commits into from Jun 13, 2012

Conversation

Projects
None yet
3 participants
Contributor

opi99 commented Jun 10, 2012

  • Added VersionControl_SVN_Comannd class with functions to build command and return execution values.
  • Refactor every Command class to use new parent class
  • Refactor VersionControl_SVN to a factory only class
  • CleanUp Coding Style
  • Check all command switches
  • Should also resolve Bug 18635 and Bug 19161

Later Bug 19470 needs to be fixed and much later something like parseOutputArray needs to be implemented for all yet missing commands (Which I doesn't need for Xinc, so maybe not my part).

Greetings Alex//

Owner

till commented Jun 11, 2012

This looks really good.

Since this package is in an early state, maybe you can also get rid off of all the PEAR_Error references and throw an exception instead? Instead of a dep on PEAR, use PEAR_Exception and then no PHP4 is necessary anymore. ;-)

Contributor

opi99 commented Jun 11, 2012

Maybe, I'll do this, if I've time.

Owner

till commented Jun 11, 2012

Yeah, it doesn't have to go into this PR, maybe in the next. :)

This is already stellar as is!

Member

mrook commented Jun 13, 2012

Yeah, this is awesome! Thanks a lot :)

@mrook mrook added a commit that referenced this pull request Jun 13, 2012

@mrook mrook Merge pull request #4 from opi99/master
Bug 19464: Add Command class and refactor code
5e3af72

@mrook mrook merged commit 5e3af72 into pear:master Jun 13, 2012

Contributor

opi99 commented Jun 13, 2012

mrook: Can you please close the mentioned pear bugs? As I don't have the rights for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment