Resolves Bug# 20203 #27

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@misilot

Github in their XML files includes a charset=utf-8 in the $headers['content-type'] variable, this accounts for that.

@misilot misilot Resolves Bug# 20203
Github in their XML files includes a UTF-8 in the $headers['content-type'] variable.
0094caa
@till
PEAR - PHP Extension and Application Repository member

@misilot I thought that was fixed in master? It's just waiting to be released.

cc @kenguest @CloCkWeRX @helgi

@misilot

I didn't test master, if it is there sorry! Is there an easy way to download the development version of pear with pear?

@kenguest
PEAR - PHP Extension and Application Repository member
@misilot

Ya, this is what I get when I tried installing master

parsePackageName(): invalid package name "package2.xml" in "package2.xml"
File "pear.conf.5" in directory "<dir name="man5">" has invalid role "man", should be one of cfg, data, doc, php, script, test, www
File "pecl.1" in directory "<dir name="man1">" has invalid role "man", should be one of cfg, data, doc, php, script, test, www
File "peardev.1" in directory "<dir name="man1">" has invalid role "man", should be one of cfg, data, doc, php, script, test, www
File "pear.1" in directory "<dir name="man1">" has invalid role "man", should be one of cfg, data, doc, php, script, test, www
Parsing of package.xml from file "package2.xml" failed
install failed
@kenguest
PEAR - PHP Extension and Application Repository member
@till
PEAR - PHP Extension and Application Repository member

@kenguest @misilot

I had a quick look, can't you get away with:

$ sh ./scripts/pear.sh package package2.xml

Here's the result:
https://www.dropbox.com/s/bwuibzo3li3byvu/PEAR-1.10.0beta1.tgz

If anyone wants to give it a try.

@till
PEAR - PHP Extension and Application Repository member
$ sh ./scripts/pear.sh install package2.xml
WARNING: "pear/Console_Getopt" is deprecated in favor of "pear/Console_GetoptPlus"
Package "pear.php.net/PEAR" dependency "pear.php.net/PEAR_Exception" has no releases
Skipping package "pear/PEAR", already installed as version 1.9.4
No valid packages found
install failed

Wanted to release PEAR_Exception but can't because the installer is not new enough:

$ pear package
Error: This package.xml requires PEAR version 1.9.5 to parse properly, we are version 1.9.4
Parsing of package.xml from file "package.xml" failed
Cannot package, errors in package file

@till
PEAR - PHP Extension and Application Repository member

OK, managed to release PEAR_Exception:

$ pear install channel://pear.php.net/PEAR_Exception-1.0.0beta1
...
$ sh ./scripts/pear.sh install -f package2.xml
...
$ pear -V
PEAR Version: 1.10.0beta1
PHP Version: 5.5.9
Zend Engine Version: 2.5.0
Running on: Darwin till-air 13.0.0 Darwin Kernel Version 13.0.0: Thu Sep 19 22:22:27 PDT 2013; root:xnu-2422.1.72~6/RELEASE_X86_64 x86_64
@till
PEAR - PHP Extension and Application Repository member

@kenguest

I reverted my temporary fix to PEAR_Exception, but I cannot upload the release. Even though pear validate works on it. Any idea?

Here is the release (pushed all changes to Github as well):

@till
PEAR - PHP Extension and Application Repository member

@misilot I hope this was not too confusing — I think you can at least test pear-core now to confirm the bugfix in master works. Thanks for helping us!

@misilot
[root@ci ~]# pear -V
PEAR Version: @pear_version@
PHP Version: 5.4.25
Zend Engine Version: 2.4.0
Running on: Linux ci 2.6.32-431.5.1.el6.x86_64 #1 SMP Tue Feb 11 13:30:01 CST 2014 x86_64
[root@ci ~]# pear remote-list -c phpqatools
Channel phpqatools Available packages:
======================================
Package         Version
PHP_CodeBrowser 1.0.3
phpqatools      1.0.2
[root@ci ~]# pear install --alldeps pear.phpqatools.org/phpqatools
downloading phpqatools-1.0.2.tgz ...
Starting to download phpqatools-1.0.2.tgz (1,054 bytes)
....done: 1,054 bytes
gpg: WARNING: unsafe permissions on homedir `/etc/pearkeys'
gpg: keyring `/etc/pearkeys/pubring.gpg' created
gpg: Signature made Mon 30 Jul 2012 06:52:28 AM EDT using DSA key ID B85B5D69
gpg: Can't check signature: No public key
install ok: channel://pear.phpqatools.org/phpqatools-1.0.2

Looks like it worked.

@till
PEAR - PHP Extension and Application Repository member

Nice!

@till
PEAR - PHP Extension and Application Repository member

On that note, I am closing this PR. And we have to release pear-core. ;(

@till till closed this Feb 22, 2014
@sad-spirit
PEAR - PHP Extension and Application Repository member

The fix is a bit half-baked, what happens if server sends 'text/xml; charset=iso-8859-1' instead?

I'd also like to draw your attention to http://news.php.net/php.pear.dev/55311

@sad-spirit
PEAR - PHP Extension and Application Repository member

Sorry, I now see the proper fix in master. Guys, there is a shitload of bugs in tracker that are probably fixed in master, why isn't anyone closing 'em?

@till
PEAR - PHP Extension and Application Repository member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment