Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug #19386 (SVN to GitHub URL's) #4

Merged
merged 6 commits into from Jun 5, 2012

Conversation

Projects
None yet
3 participants
Member

pce commented May 24, 2012

bootstrap svn urls to redirect to github.

Looks like we need to get the tags & branches in place before this can be replaced.

Owner

pce replied May 25, 2012

the problem was that the in the first PR the download_url function sends a plain HTTP request.
I extended download_url to detect https urls and send it as a ssl request.
And i solved a dependency of 'PEAR5.php'.
I updated the commit range, tested it and the pearweb installation worked.

Owner

pce replied May 26, 2012

...another Option is to create a pear github page.
Those resources are accessible over http, eg. http://pear.github.com/pear-core/PEAR5.php
like http://documentcloud.github.com/underscore/underscore-min.js

Style - avoid single line if () statements without braces please :)

Style - 4 space soft tab + braces

Indentation

Owner

CloCkWeRX commented Jun 2, 2012

Thanks for the pull request.

So, the tricky thing here (and why we've quietly ignored this a bit too long) is the existance of go-pear.phar.

See http://pear.php.net/manual/en/installation.getting.php

http://pear.php.net/bugs/bug.php?id=19131

Member

pce commented Jun 4, 2012

i don't think go-pear.phar needs a webinterface,
but go-pear.php is a nice alternative for shared webhosting and therefore mentioned in the manual.

One more set of braces

CloCkWeRX added a commit that referenced this pull request Jun 5, 2012

Merge pull request #4 from pce/master
Bug #19386  (SVN to GitHub URL's)

@CloCkWeRX CloCkWeRX merged commit e0b881b into pear:master Jun 5, 2012

Owner

CloCkWeRX commented Jun 5, 2012

Thanks for the PR, I'll get around to pushing it onto pearweb in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment