Possible fix for #3, plus CS fixes #4

Merged
merged 3 commits into from Feb 7, 2012

Conversation

Projects
None yet
2 participants
@boenrobot
Member

boenrobot commented Feb 5, 2012

I've made a fix for #3, in that in the presense of other autoloaders, an exception will not be thrown.

I'm not sure how to write a test for that though, since there isn't a test that triggers the current exception with only the one autoloader (they trigger fatal errors instead).

I've also fixed most CS issues (missing docs, long lines...). The ones remaining are "conditional include...; use include instead" ones, but I'm not entirely sure of the implications, so I've left those intact.

edit: While I'm at it, I noticed loadSuccessful() could be improved.

saltybeagle added a commit that referenced this pull request Feb 7, 2012

Merge pull request #4 from boenrobot/master
Possible fix for #3, plus CS fixes

@saltybeagle saltybeagle merged commit d24b0d7 into pear2:master Feb 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment