change to :os.system_time to avoid using invalid time while checking token expiry - #169
Merged
Conversation
Collaborator
|
Thank you for the PR. We had a similar PR before, #158, and I didn't realise there were leftovers. Could you while at it change all the other System.system_time occurrences when it makes sense? Also could you use |
Contributor
Author
|
hey @wojtekmach, I have updated the PR. Thanks for the quick response! |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently
System.system_timeis used to get current time, which is used for checking whether the token is expired.System.system_timeis affected by time warpnote that the lag between
:os.system_timeandSystem.system_timewas a lot in my casedue to this,
Goth.fetchreturns expired tokens which are no longer valid. the only solution when this happens is to reboot the system. This PR changes it to use:os.system_time.