New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trie key sequence #146

Merged
merged 16 commits into from Jul 7, 2014

Conversation

Projects
None yet
4 participants
@lestrrat
Contributor

lestrrat commented Jul 6, 2014

This branch completely changes the key-sequence matching algorithm from a LL-ish hash-of-hash traversal to actual sequence of keys.

refs #124, #137, #139, #140

lestrrat added some commits Jul 4, 2014

Tweak AcceptKey function
Now the functin properly handles unmatched sequences, and does the what
the original keybinding was supposed to do instead of doing... nothing
Change rules for receiving key sequences
* Longest sequence always wins
* If you would like to break out of typing in a sequence, you must
  call peco.Cancel
* The Konami command now needs to start with C-x

TODO: remove all that Keymap code that doesn't get used anymore
Various
* Alt key mod now work again
* Use TrimSpace
* Remove some unused code (need to delete a LOT more)
Various structural changes
* Compile ahocorosick matcher laizly
* Move key mappings to keyseq, as we do not directly interface them in
  the main peco package
@lestrrat

This comment has been minimized.

Show comment
Hide comment
@lestrrat

lestrrat Jul 6, 2014

Contributor

@mattn @syohex please review when you have the time :)

Contributor

lestrrat commented Jul 6, 2014

@mattn @syohex please review when you have the time :)

@koron

This comment has been minimized.

Show comment
Hide comment
@koron

koron commented Jul 6, 2014

👍

@syohex

This comment has been minimized.

Show comment
Hide comment
@syohex

syohex Jul 6, 2014

Contributor

👍

I have used this version for a little. I can't find any regressions for now.
(This change is too big and little difficult for me...)

Contributor

syohex commented Jul 6, 2014

👍

I have used this version for a little. I can't find any regressions for now.
(This change is too big and little difficult for me...)

@mattn

This comment has been minimized.

Show comment
Hide comment
@mattn

mattn Jul 7, 2014

Contributor

👍

Sorry for delay!

Contributor

mattn commented Jul 7, 2014

👍

Sorry for delay!

@lestrrat

This comment has been minimized.

Show comment
Hide comment
@lestrrat

lestrrat Jul 7, 2014

Contributor

いえーい

Contributor

lestrrat commented Jul 7, 2014

いえーい

lestrrat added a commit that referenced this pull request Jul 7, 2014

@lestrrat lestrrat merged commit 7054460 into master Jul 7, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
continuous-integration/wercker Build finished
Details

@lestrrat lestrrat deleted the trie_key_sequence branch Jul 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment