New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swh login #1

Merged
merged 6 commits into from Jun 26, 2016

Conversation

Projects
None yet
2 participants
@pedantix
Owner

pedantix commented Jun 26, 2016

No description provided.

Shaun Hubbard
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
Show outdated Hide outdated db/schema.rb
@@ -11,7 +11,7 @@
#
# It's strongly recommended that you check this file into your version control system.
ActiveRecord::Schema.define(version: 20160625213540) do
ActiveRecord::Schema.define(version: 20160625235725) do

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Separate every 3 digits in the integer portion of a number with underscores(_).

@houndci-bot

houndci-bot Jun 26, 2016

Separate every 3 digits in the integer portion of a number with underscores(_).

Shaun Hubbard
t.string 'reset_password_token'
t.datetime 'reset_password_sent_at'
t.datetime 'remember_created_at'
t.integer 'sign_in_count', default: 0, null: false

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Unnecessary spacing detected.

@houndci-bot

houndci-bot Jun 26, 2016

Unnecessary spacing detected.

end
add_index 'users', ['email'], name: 'index_users_on_email', unique: true, using: :btree
add_index 'users', ['reset_password_token'], name: 'index_users_on_reset_password_token', unique: true, using: :btree

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [119/80]

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [119/80]

t.datetime 'updated_at', null: false
end
add_index 'users', ['email'], name: 'index_users_on_email', unique: true, using: :btree

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [89/80]

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [89/80]

end
add_index "delayed_jobs", ["priority", "run_at"], name: "delayed_jobs_priority", using: :btree
add_index 'delayed_jobs', ['priority', 'run_at'], name: 'delayed_jobs_priority', using: :btree

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [96/80]
Use %w or %W for an array of words.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [96/80]
Use %w or %W for an array of words.

create_table :users do |t|
## Database authenticatable
t.string :email, null: false, default: ""
t.string :encrypted_password, null: false, default: ""

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@houndci-bot

houndci-bot Jun 26, 2016

Prefer single-quoted strings when you don't need string interpolation or special symbols.

def change
create_table :users do |t|
## Database authenticatable
t.string :email, null: false, default: ""

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@houndci-bot

houndci-bot Jun 26, 2016

Prefer single-quoted strings when you don't need string interpolation or special symbols.

# t.string :unlock_token # Only if unlock strategy is :email or :both
# t.datetime :locked_at

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Extra blank line detected.

@houndci-bot

houndci-bot Jun 26, 2016

Extra blank line detected.

@@ -0,0 +1,42 @@
class DeviseCreateUsers < ActiveRecord::Migration

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Missing top-level class documentation comment.

@houndci-bot

houndci-bot Jun 26, 2016

Missing top-level class documentation comment.

@@ -0,0 +1,42 @@
class DeviseCreateUsers < ActiveRecord::Migration
def change

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Method has too many lines. [15/10]

@houndci-bot

houndci-bot Jun 26, 2016

Method has too many lines. [15/10]

# t.string :unconfirmed_email # Only if using reconfirmable
## Lockable
# t.integer :failed_attempts, default: 0, null: false # Only if lock strategy is :failed_attempts

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [104/80]

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [104/80]

b.optional :readonly
b.wrapper :container_wrapper, tag: 'div', class: 'small-offset-3 small-9 columns' do |ba|
ba.wrapper :tag => 'label', :class => 'checkbox' do |bb|

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Use the new Ruby 1.9 hash syntax.

@houndci-bot

houndci-bot Jun 26, 2016

Use the new Ruby 1.9 hash syntax.

end
# Examples of use:
# - wrapper_html: {class: 'row'}, custom_wrapper_html: {class: 'column small-12'}

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [83/80]

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [83/80]

# Note that you need to adapt this wrapper to your needs. If you need a 4
# columns form then change the wrapper class to 'small-3', if you need
# only two use 'small-6' and so on.
config.wrappers :inline_form, tag: 'div', class: 'column small-4', hint_class: :field_with_hint, error_class: :error do |b|

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [125/80]

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [125/80]

b.use :html5
b.optional :readonly
b.wrapper :container_wrapper, tag: 'div', class: 'small-offset-3 small-9 columns' do |ba|

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [93/80]

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [93/80]

end
end
config.wrappers :horizontal_radio_and_checkboxes, tag: 'div', class: 'row' do |b|

This comment has been minimized.

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [83/80]

@houndci-bot

houndci-bot Jun 26, 2016

Line is too long. [83/80]

@pedantix pedantix merged commit d9bbd87 into development Jun 26, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound 57 violations found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment