links added #13

Merged
merged 4 commits into from Jul 24, 2016

Conversation

Projects
None yet
2 participants
@pedantix
Owner

pedantix commented Jul 24, 2016

No description provided.

Shaun Hubbard
spec/features/directive_resource_spec.rb
+ visit root_path
+ click_on "Sign In"
+ fill_form :user, email: user.email, password: user.password
+

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

spec/features/directive_resource_spec.rb
@@ -11,6 +11,24 @@
expect(page).not_to have_link t("application.top_bar.edit_directive")
expect(page).not_to have_link t("application.top_bar.create_directive")
+
+

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Extra blank line detected.

@houndci-bot

houndci-bot Jul 24, 2016

Extra blank line detected.

spec/features/directive_resource_spec.rb
+ expect(page).to have_text directive.content
+
+ expect(page).to have_link t("application.top_bar.edit_directive")
+ expect(page).to have_link t("pages.home.download_directive"), href: qr_code_user_directives_path(user)

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Line is too long. [106/80]

@houndci-bot

houndci-bot Jul 24, 2016

Line is too long. [106/80]

spec/features/directive_resource_spec.rb
@@ -11,6 +11,24 @@
expect(page).not_to have_link t("application.top_bar.edit_directive")
expect(page).not_to have_link t("application.top_bar.create_directive")
+
+
+ expect(page).not_to have_link t("pages.home.download_directive"), href: qr_code_user_directives_path(user)

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Line is too long. [110/80]

@houndci-bot

houndci-bot Jul 24, 2016

Line is too long. [110/80]

+ expect(subject).to respond_with :ok
+ expect(response.body).to eq qr_svg_xml
+ end
+ end

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

+ module_size: 9)
+ end
+
+ context 'GET #qr_code' do

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

+ end
+
+ context 'GET #qr_code' do
+ it 'should respond with svg xml' do

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@houndci-bot

houndci-bot Jul 24, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

+ url = user_directives_url(user)
+ qrcode = RQRCode::QRCode.new(url)
+
+ qrcode.as_svg(offset: 0, color: '000',

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Trailing whitespace detected.

@houndci-bot

houndci-bot Jul 24, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Trailing whitespace detected.

@@ -0,0 +1,22 @@
+require 'rails_helper'

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@houndci-bot

houndci-bot Jul 24, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

+
+ qrcode.as_svg(offset: 0, color: '000',
+ shape_rendering: 'crispEdges',
+ module_size: 9)

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Align the elements of a hash literal if they span more than one line.

@houndci-bot

houndci-bot Jul 24, 2016

Align the elements of a hash literal if they span more than one line.

+ qrcode = RQRCode::QRCode.new(url)
+
+ qrcode.as_svg(offset: 0, color: '000',
+ shape_rendering: 'crispEdges',

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Align the elements of a hash literal if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Trailing whitespace detected.

@houndci-bot

houndci-bot Jul 24, 2016

Align the elements of a hash literal if they span more than one line.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Trailing whitespace detected.

app/controllers/directives_controller.rb
+ #render text: qr_helper(user), status: :ok
+ svg_file = Tempfile.new(['qr_code', '.svg'])
+ svg_file.write qr_helper(user)
+ send_file svg_file, type: "image/svg+xml",

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

app/controllers/directives_controller.rb
@@ -35,6 +36,14 @@ def destroy
redirect_to root_path
end
+ def qr_code
+ #render text: qr_helper(user), status: :ok
+ svg_file = Tempfile.new(['qr_code', '.svg'])

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@houndci-bot

houndci-bot Jul 24, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

app/controllers/directives_controller.rb
@@ -35,6 +36,14 @@ def destroy
redirect_to root_path
end
+ def qr_code
+ #render text: qr_helper(user), status: :ok

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Missing space after #.

@houndci-bot

houndci-bot Jul 24, 2016

Missing space after #.

Shaun Hubbard
spec/features/directive_resource_spec.rb
+ expect(page).to have_text directive.content
+
+ expect(page).to have_link t("application.top_bar.edit_directive")
+ expect(page).to have_link t("pages.home.download_directive"),

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

@houndci-bot

houndci-bot Jul 24, 2016

Trailing whitespace detected.

spec/features/directive_resource_spec.rb
@@ -11,6 +11,23 @@
expect(page).not_to have_link t("application.top_bar.edit_directive")
expect(page).not_to have_link t("application.top_bar.create_directive")
+ expect(page).not_to have_link t("pages.home.download_directive"), href: qr_code_user_directives_path(user)

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Line is too long. [110/80]

@houndci-bot

houndci-bot Jul 24, 2016

Line is too long. [110/80]

Shaun Hubbard
spec/features/directive_resource_spec.rb
@@ -11,6 +11,24 @@
expect(page).not_to have_link t("application.top_bar.edit_directive")
expect(page).not_to have_link t("application.top_bar.create_directive")
+ expect(page).not_to have_link t("pages.home.download_directive"),
+ href: qr_code_user_directives_path(user)

This comment has been minimized.

@houndci-bot

houndci-bot Jul 24, 2016

Align the parameters of a method call if they span more than one line.

@houndci-bot

houndci-bot Jul 24, 2016

Align the parameters of a method call if they span more than one line.

Shaun Hubbard

@pedantix pedantix merged commit 1d4189c into development Jul 24, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound 4 violations found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment