New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Jetty's SslContextFactory object directly #449

Closed
schaffer opened this Issue Jul 15, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@schaffer

schaffer commented Jul 15, 2016

SslContextFactory has many options to be set, so it is useful to build the object externally and pass it to the embedded Jetty.

Also, Jetty allows us to create another class that overrides methods in SslContextFactory and use this class instead (this is done by changing XML files in the standalone Jetty).
In our case (Nubank), we change SslContextFactory to fetch the keystore directly from S3.

We managed that by adding the parameter :ssl-context-factory and changing ssl-context-factory function: https://github.com/nubank/pedestal/blob/ssl-context-factory/jetty/src/io/pedestal/http/jetty.clj#L44

@ohpauleez ohpauleez added the primed label Jul 20, 2016

@ohpauleez ohpauleez added this to the 0.5.1 milestone Jul 20, 2016

@ohpauleez

This comment has been minimized.

Show comment
Hide comment
@ohpauleez

ohpauleez Aug 26, 2016

Member

This is now on master. Thanks!

Member

ohpauleez commented Aug 26, 2016

This is now on master. Thanks!

@ohpauleez ohpauleez closed this Aug 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment