Not found option #216
Merged
Not found option #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,6 +162,14 @@ | |||
| (servlet/servlet :service service-fn))) | |||
|
|
|||
| (defn create-servlet | |||
| "Creates a servlet given an options map with keyword keys prefixed by namespace e.g. | |||
| :io.pedestal.service.http/interceptors or bootstrap/interceptors if the namespace is aliased to bootstrap. | |||
There was a problem hiding this comment.
Is this supposed to be bootstrap/interceptors or :bootstrap/interceptors?
There was a problem hiding this comment.
Technically it would be ::bootstrap/interceptors. I'll update it
|
I had one question about whether something was a symbol or a keyword, but otherwise feel free to merge this @cldwalker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some useful docs for additional options users can pass in from their service.clj