Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementation of heartbeat scheduling #250

Closed
wants to merge 2 commits into from
Closed

Fix implementation of heartbeat scheduling #250

wants to merge 2 commits into from

Commits on Feb 24, 2014

  1. Fix implementation of heartbeat scheduling 

    Heartbeat functionality in pedestal uses class Executors
from package java.util.concurrent, its method newScheduledThreadPool
is used to initialize thread pool for sse heartbeat functionality.
However, threads created by default are non-daemon threads where
they really should be rather daemon threads, so they don't prevent
the JVM process from exiting.

My fix supplies ThreadFactory for newScheduledThreadPool, this factory
just sets every jvm thread in the thread pool to be daemon thread.
    @janherich
    janherich committed Feb 24, 2014
    Copy the full SHA
    36dfc05 View commit details
    Browse the repository at this point in the history

  2. Formatting changes

    @janherich
    janherich committed Feb 24, 2014
    Copy the full SHA
    9aa7543 View commit details
    Browse the repository at this point in the history