InputStream should be closed (Fix #266) #270

Closed
wants to merge 1 commit into
from

2 participants

@mamciek

When InputStream or File was given as a :body then it was consumed but
never closed causing "Too many open files" errors.

I have also added two new tests:

  • check if InputStream is read and closed
  • check if File is read

This pull request replaces #267

@mamciek mamciek changed the title from InputStream and File should be closed (Fix #266) to InputStream should be closed (Fix #266) Jul 23, 2014
@mamciek

@ohpauleez "I want to clean up the code a bit. And we'll need a test to confirm the closes happen now." - from #267

@ohpauleez What kind of cleanup are you planning?

@mamciek mamciek closed this Jul 23, 2014
@mamciek mamciek reopened this Jul 23, 2014
@mamciek mamciek InputStream should be closed (Fix #266)
When InputStream was given as a :body then it was consumed but
never closed causing "Too many open files" errors.
44afd02
@mamciek

@ohpauleez any chances on merging that?

@ohpauleez
Pedestal member

Working on it today. This exact PR may not get merged, but this issue will be addressed and a fix applied to master today.

@ohpauleez
Pedestal member

Thanks so much for the submission and leg work.
This was fixed in: pedestal/pedestal@8281b80

The tests were very helpful

@ohpauleez ohpauleez closed this Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment