Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks applied #21

Merged
merged 3 commits into from Aug 8, 2017
Merged

Minor tweaks applied #21

merged 3 commits into from Aug 8, 2017

Conversation

leo
Copy link
Contributor

@leo leo commented Aug 2, 2017

Awesome package! 馃槉 Here are a few tweaks to make it even better.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bd76d1c on leo:master into 7779f33 on pedronauck:master.

@sammdec
Copy link

sammdec commented Aug 5, 2017

Is there any chance of this getting merged and released soon? @pedronauck

@sammdec
Copy link

sammdec commented Aug 5, 2017

Actually it looks like after installing @leo forked version that this PR is based on it actually breaks micro-router but not sending a response

@sammdec
Copy link

sammdec commented Aug 7, 2017

Ignore my comments above this has been solved with vercel/micro-dev#16

@pedronauck pedronauck closed this Aug 7, 2017
@leo
Copy link
Contributor Author

leo commented Aug 8, 2017

@pedronauck Why did you close this?

@pedronauck pedronauck reopened this Aug 8, 2017
@pedronauck
Copy link
Owner

Sorry @leo, I closed the wrong thing 馃槀

@pedronauck pedronauck merged commit 35dd663 into pedronauck:master Aug 8, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bd76d1c on leo:master into 7779f33 on pedronauck:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants