Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visibility and initialization #49

Closed
lprone opened this issue Feb 7, 2019 · 4 comments
Closed

visibility and initialization #49

lprone opened this issue Feb 7, 2019 · 4 comments

Comments

@lprone
Copy link
Contributor

lprone commented Feb 7, 2019

Algorithms/src/main/java/com/github/pedrovgs/problem46/BinaryTreeSerialization.java

Line 54 in 7729e81

static int index = 0;

This variable could be defined as:
private int index;
and placed above the methods
@lprone
Copy link
Contributor Author

lprone commented Feb 7, 2019

Algorithms/src/main/java/com/github/pedrovgs/problem37/PathCalculator.java

Line 30 in 7729e81

public static final String DIR_SEPARATOR = "/";

Here you can define as:
private static final String DIR_SEPARATOR = "/";

@pedrovgs
Copy link
Owner

pedrovgs commented Feb 7, 2019

Hi @lprone thanks for your suggestions. Could you send a PR with the changes proposed?

@lprone lprone mentioned this issue Feb 7, 2019
Merged
@lprone
Copy link
Contributor Author

lprone commented Feb 7, 2019

Hi @lprone thanks for your suggestions. Could you send a PR with the changes proposed?

Done

@pedrovgs
Copy link
Owner

Great thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lprone @pedrovgs