Include the ControllerHelpers directly into `ActionController::Base`. #41

Merged
merged 1 commit into from Dec 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

lucasmazza commented Dec 3, 2013

Including on ApplicationController won't affect controllers inside engines,
and breaks such controllers when used with peek-rblineprof as it extends
AC::Base directly.

This also makes the Spork specific setup and the Peek.setup API unnecessary.

Include the ControllerHelpers directly into `ActionController::Base`.
Including on `ApplicationController` won't affect controllers inside
engines, and breaks such controllers when used with `peek-rblineprof`
as it extends `AC::Base` directly.

dewski added a commit that referenced this pull request Dec 3, 2013

Merge pull request #41 from lucasmazza/lm-include-peek-on-ac-base
Include the ControllerHelpers directly into `ActionController::Base`.

@dewski dewski merged commit 8ff398b into peek:master Dec 3, 2013

Owner

dewski commented Dec 3, 2013

Thanks for the PR! Released v0.1.8 on Rubygems.

@lucasmazza lucasmazza deleted the lucasmazza:lm-include-peek-on-ac-base branch Dec 3, 2013

Contributor

lucasmazza commented Dec 3, 2013

@dewski thanks a lot for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment