Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings #85

Merged
merged 1 commit into from Feb 3, 2016
Merged

Remove deprecation warnings #85

merged 1 commit into from Feb 3, 2016

Conversation

mgrachev
Copy link
Contributor

@mgrachev mgrachev commented Jan 25, 2016

Use method prepend_before_action instead prepend_before_filter and
request.env instead env.

DEPRECATION WARNING: prepend_before_filter is deprecated and will be removed in Rails 5.1. Use prepend_before_action instead. (called from block in <module:ControllerHelpers> at /Users/mgrachev/peek/lib/peek/controller_helpers.rb:6)
DEPRECATION WARNING: env is deprecated and will be removed from Rails 5.0. (called from set_peek_request_id at /Users/mgrachev/peek/lib/peek/controller_helpers.rb:13)

Use method prepend_before_action instead prepend_before_filter and
request.env instead env
@dewski
Copy link
Member

@dewski dewski commented Feb 3, 2016

Use method prepend_before_action instead prepend_before_filter and
request.env instead env.

I don't have any data on the number of installs for 3.x, but I like the idea of merging these 👍

dewski added a commit that referenced this issue Feb 3, 2016
@dewski dewski merged commit 1191205 into peek:master Feb 3, 2016
1 check failed
@dewski
Copy link
Member

@dewski dewski commented Mar 4, 2016

Released this in v0.2.0 and pushed to Rubygems.

@mgrachev
Copy link
Contributor Author

@mgrachev mgrachev commented Mar 4, 2016

Good news! 🎉

@mgrachev mgrachev deleted the remove-deprecation-warnings branch Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants