Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change regex in extractLoader.js #7

Merged
merged 1 commit into from May 22, 2017

Conversation

@heptahedron
Copy link

heptahedron commented May 11, 2016

The regex used in the loader is a bit overzealous and prevents inclusion of scripts in the same manner allowed for images and styles. This should limit it to only the applicable file that needs to be executed, though I would like to change the conditional to something that indicates more absolutely that css-loader is being used.

…ader` js files, allowing inclusion of scripts a la images and stylesheets
@coveralls

This comment has been minimized.

Copy link

coveralls commented May 11, 2016

Coverage Status

Coverage remained the same at 97.917% when pulling 20930c1 on heptahedron:master into 75ed1fa on peerigon:master.

@teazean

This comment has been minimized.

Copy link

teazean commented Apr 27, 2017

I need this patch, too.
I changed the reg to /node_modules.*?\.js$/i locally.

@teazean

This comment has been minimized.

Copy link

teazean commented Apr 27, 2017

Can someone merge this ?

@jhnns jhnns merged commit 84f7f93 into peerigon:master May 22, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.917%
Details
@purell purell referenced this pull request Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.