New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IX-F importer fails on nulled ipv4 / ipv6 properties in vlan_list entries #1244
Comments
@peeringdb/pc please make this an ASAP. It was reported by me and is an active problem. Thanks. |
+1 clear bug |
+1
…On Wed, Sep 14, 2022 at 10:17 mcmanuss8 ***@***.***> wrote:
+1 clear bug
—
Reply to this email directly, view it on GitHub
<#1244 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFA2YQTZFEXDYQMIQDPYJXDV6HNA7ANCNFSM6AAAAAAQMDYF4Y>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
@vegu, please generally accept |
IX-F importer fails on nulled ipv4 / ipv6 properties in vlan_list entries #1244 See merge request gh/peeringdb/peeringdb!320
* Add export tool to https://peeringdb.com/cp/peeringdb_server #586 * IX-F importer fails on nulled ipv4 / ipv6 properties in vlan_list entries #1244 * Adding a POC must require an email address or phone number #1044 * Selenium tests * ping django-peeringdb and rdap and poetry relock * linting * linting * remove selenium tests cruft * comment out django-peeringdb and search data mounts * regen docs
* Add export tool to https://peeringdb.com/cp/peeringdb_server peeringdb#586 * IX-F importer fails on nulled ipv4 / ipv6 properties in vlan_list entries peeringdb#1244 * Adding a POC must require an email address or phone number peeringdb#1044 * Selenium tests * ping django-peeringdb and rdap and poetry relock * linting * linting * remove selenium tests cruft * comment out django-peeringdb and search data mounts * regen docs
The traceback has evolved with this update, but the problem remains. On production, the following is reported:
While on beta, with the new code, this is reported:
|
An if_list of:
rather than the normal likes of:
seems to be tripping up the importer. This null passes the https://ixpdb.euro-ix.net/en/validator/ validator. |
This new code worked successfully on beta this 0000 UTC run of the Importer. Nice work! |
Describe the bug
Currently the importer will raise an error when encountering
null
values foripv6
oripv4
properties in thevlan_list
property.Expected behavior
It's valid according to the IX-F schema, and the importer should support it by treating it the same way as if the property (
ipv6
oripv4
) was not there at all.Are there security concerns?
no
Are there privacy concerns?
no
The text was updated successfully, but these errors were encountered: