Skip to content

Changing ASN field on "Add Network" to be numbers only #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rapdodge opened this issue Aug 25, 2023 · 7 comments · Fixed by #1506
Closed

Changing ASN field on "Add Network" to be numbers only #1430

rapdodge opened this issue Aug 25, 2023 · 7 comments · Fixed by #1506
Assignees
Labels
Time:Minor Up to 4 hours
Milestone

Comments

@rapdodge
Copy link

Is your feature request related to a problem? Please describe.
Yes, because if ASN field are not number only, it got 500 Error

Who is affected by the problem?
Me (and maybe others)

What is the impact?
Error 500 when you wanted to adding ASN

Are there security concerns?
No

Are there privacy concerns?
No

Describe the solution you'd like
Changing the ASN field on "Add Network" from text to number

Do you think this feature will require a formal design?
No, because it's just changing the input type from text to number

Describe alternatives you've considered
No alternative

Could this feature request need support from the Admin Committee?
No

What is the proposed priority?
Low, but it's nice if will be changed to next release

Provide a rationale for any/all of the above

Additional context
image

Field that outlined input type should be changed from text to number. Since if people don't know that field should be number only, it will got error 500

@martinhannigan
Copy link

martinhannigan commented Aug 25, 2023 via email

@arnoldnipper arnoldnipper self-assigned this Aug 26, 2023
@arnoldnipper arnoldnipper added this to the 1 Decide milestone Aug 26, 2023
@arnoldnipper
Copy link
Contributor

+1 ... my suggestion is to strip "AS" and "ASN" if they should occur. That's in line what we do on the user/AC interfaces.

@martinhannigan
Copy link

martinhannigan commented Aug 26, 2023 via email

@mcmanuss8
Copy link
Contributor

+1

1 similar comment
@grizz
Copy link
Member

grizz commented Sep 7, 2023

+1

@grizz
Copy link
Member

grizz commented Sep 7, 2023

Summary

Make this a number only field, and/or strip out AS|ASN so it doesn't fail validation.

@martinhannigan
Copy link

martinhannigan commented Sep 7, 2023 via email

@grizz grizz added the Time:Minor Up to 4 hours label Sep 8, 2023
vegu pushed a commit that referenced this issue Jan 15, 2024
Add a "flag bad data" button on various places #170
Add a "last synced at $date" to beta.peeringdb.com #410
Improve RIR Update Procedure #1303
Only indicate availability of DC voltage for facilities #1341
Clarifying the Network Type field #1357
Changing ASN field on "Add Network" to be numbers only #1430
Update website to take advantage of wider screen and improve mobile device support #1463
v2 search - not able to find IX participant based on IP #1469
v2 search not able to find organization and network - Marconi Solutions Srls #1476
Improve RIR Update Procedure #1280
@vegu vegu mentioned this issue Jan 15, 2024
grizz pushed a commit that referenced this issue Jan 15, 2024
Add a "flag bad data" button on various places #170
Add a "last synced at $date" to beta.peeringdb.com #410
Improve RIR Update Procedure #1303
Only indicate availability of DC voltage for facilities #1341
Clarifying the Network Type field #1357
Changing ASN field on "Add Network" to be numbers only #1430
Update website to take advantage of wider screen and improve mobile device support #1463
v2 search - not able to find IX participant based on IP #1469
v2 search not able to find organization and network - Marconi Solutions Srls #1476
Improve RIR Update Procedure #1280

Co-authored-by: 20C <code@20c.com>
@leovegoda leovegoda modified the milestones: Next Release, 2.54.2 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Time:Minor Up to 4 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants