-
Notifications
You must be signed in to change notification settings - Fork 117
Changing ASN field on "Add Network" to be numbers only #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1
Friendly suggestion to pop an error that says something like text detected,
try without using the letters "AS" or something similar.
…On Thu, Aug 24, 2023 at 8:01 PM Rifqi Arief ***@***.***> wrote:
*Is your feature request related to a problem? Please describe.*
Yes, because if ASN field are not number only, it got 500 Error
*Who is affected by the problem?*
Me (and maybe others)
*What is the impact?*
Error 500 when you wanted to adding ASN
*Are there security concerns?*
No
*Are there privacy concerns?*
No
*Describe the solution you'd like*
Changing the ASN field on "Add Network" from text to number
*Do you think this feature will require a formal design?*
No, because it's just changing the input type from text to number
*Describe alternatives you've considered*
No alternative
*Could this feature request need support from the Admin Committee?*
No
*What is the proposed priority?*
Low, but it's nice if will be changed to next release
*Provide a rationale for any/all of the above*
*Additional context*
[image: image]
<https://user-images.githubusercontent.com/33513626/263131639-c5ae52e6-58c1-4617-9848-ef2893f8a409.png>
Field that outlined input type should be changed from text to number.
Since if people don't know that field should be number only, it will got
error 500
—
Reply to this email directly, view it on GitHub
<#1430>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFA2YQU27AT7AVHO7TPSXA3XW7TNTANCNFSM6AAAAAA35XTDNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
+1 ... my suggestion is to strip "AS" and "ASN" if they should occur. That's in line what we do on the user/AC interfaces. |
that works too. Sounds like this is cleaner.
…On Sat, Aug 26, 2023 at 08:39 Arnold Nipper ***@***.***> wrote:
+1 ... my suggestion is to strip "AS" and "ASN" if they should occur.
That's in line what we do on the user/AC interfaces.
—
Reply to this email directly, view it on GitHub
<#1430 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFA2YQVDXCBVNTUKORN5SVTXXHVADANCNFSM6AAAAAA35XTDNY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
+1 |
1 similar comment
+1 |
Summary Make this a number only field, and/or strip out AS|ASN so it doesn't fail validation. |
+1
…On Thu, Sep 7, 2023 at 12:12 PM Matt Griswold ***@***.***> wrote:
*Summary*
Make this a number only field, and/or strip out AS|ASN so it doesn't fail
validation.
—
Reply to this email directly, view it on GitHub
<#1430 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFA2YQWVK3XFY7SLV5BHVOTXZHXAHANCNFSM6AAAAAA35XTDNY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
vegu
pushed a commit
that referenced
this issue
Jan 15, 2024
Add a "flag bad data" button on various places #170 Add a "last synced at $date" to beta.peeringdb.com #410 Improve RIR Update Procedure #1303 Only indicate availability of DC voltage for facilities #1341 Clarifying the Network Type field #1357 Changing ASN field on "Add Network" to be numbers only #1430 Update website to take advantage of wider screen and improve mobile device support #1463 v2 search - not able to find IX participant based on IP #1469 v2 search not able to find organization and network - Marconi Solutions Srls #1476 Improve RIR Update Procedure #1280
Merged
grizz
pushed a commit
that referenced
this issue
Jan 15, 2024
Add a "flag bad data" button on various places #170 Add a "last synced at $date" to beta.peeringdb.com #410 Improve RIR Update Procedure #1303 Only indicate availability of DC voltage for facilities #1341 Clarifying the Network Type field #1357 Changing ASN field on "Add Network" to be numbers only #1430 Update website to take advantage of wider screen and improve mobile device support #1463 v2 search - not able to find IX participant based on IP #1469 v2 search not able to find organization and network - Marconi Solutions Srls #1476 Improve RIR Update Procedure #1280 Co-authored-by: 20C <code@20c.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Yes, because if ASN field are not number only, it got 500 Error
Who is affected by the problem?
Me (and maybe others)
What is the impact?
Error 500 when you wanted to adding ASN
Are there security concerns?
No
Are there privacy concerns?
No
Describe the solution you'd like
Changing the ASN field on "Add Network" from text to number
Do you think this feature will require a formal design?
No, because it's just changing the input type from text to number
Describe alternatives you've considered
No alternative
Could this feature request need support from the Admin Committee?
No
What is the proposed priority?
Low, but it's nice if will be changed to next release
Provide a rationale for any/all of the above
Additional context

Field that outlined input type should be changed from text to number. Since if people don't know that field should be number only, it will got error 500
The text was updated successfully, but these errors were encountered: