New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current IXF member list import rules #237

Open
grizz opened this Issue Nov 13, 2017 · 12 comments

Comments

Projects
None yet
5 participants
@grizz
Copy link
Member

grizz commented Nov 13, 2017

Import rules

Default setting just decides if networks have to opt in or opt out.

allow_ixp_update: no

  • If a network has an IX entry with both invalid IP addresses, the network IX entry is removed
  • If a network has an IX entry with any other invalid information (route server peer and speed), nothing is done
  • If a network does not have an entry for the IX, nothing is done

allow_ixp_update: yes

  • If a network has an IX entry with any invalid information, the entry is updated
  • If a network does not have an entry for the IX, one is added
  • If a network does not have an entry in the IX member list, the network IX entry is removed

only IP addresses within the IX prefix sets are added

AC Tools

All changes made by the importer are logged to the control panel, available to the AC, and able to be rolled back with a single click.

full documentation was provided to the AC 2017-11-01

@arnoldnipper

This comment has been minimized.

Copy link
Contributor

arnoldnipper commented Nov 14, 2017

What is the default setting for allow_ixp_update?

@grizz

This comment has been minimized.

Copy link
Member Author

grizz commented Nov 14, 2017

As of version 2.6.4, which is now on beta, the default allow_ixp_update is now no (#238).

@ccaputo

This comment has been minimized.

Copy link

ccaputo commented Nov 20, 2017

Is "state = active" in the JSON connection_list being required? I'm pondering how participants that are on hiatus are handled.

Is it expected that they will lose their PeeringDB listing in the IXP list when on hiatus, if marked "state = inactive". And then when they return to active state, they will either need allow_ix_update set to yes for an automatic update, or they will need to do a manual update?

@vegu

This comment has been minimized.

Copy link
Contributor

vegu commented Nov 20, 2017

Is it expected that they will lose their PeeringDB listing in the IXP list when on hiatus, if marked "state = inactive". And then when they return to active state, they will either need allow_ix_update set to yes for an automatic update, or they will need to do a manual update?

Correct.

Note: If a state is not set at all, it will be seen as active by default. If state is set the importer accepts either "active" or "connected" to qualify the entry for import.

@arnoldnipper

This comment has been minimized.

Copy link
Contributor

arnoldnipper commented Feb 24, 2018

allow_ixp_update: no && If a network has an IX entry with both invalid IP addresses, the network IX entry is removed

Q: @vegu Do both IP addresses have to be invalid for the network entry to be removed?

@bijals

This comment has been minimized.

Copy link

bijals commented Feb 24, 2018

Will the network be notified that their incorrect entry has been removed?

@vegu

This comment has been minimized.

Copy link
Contributor

vegu commented Feb 24, 2018

Q: @vegu Do both IP addresses have to be invalid for the network entry to be removed?

@arnoldnipper yes

Will the network be notified that their incorrect entry has been removed?

@bijals no

@bijals

This comment has been minimized.

Copy link

bijals commented Feb 24, 2018

I think it would be good for the network to be notified if their data is changed/removed. If I was a network and my data in the database was being changed, i would want to know.
What do others think?

@arnoldnipper

This comment has been minimized.

Copy link
Contributor

arnoldnipper commented Feb 24, 2018

I think it would be good for the network to be notified if their data is changed/removed. If I was a
network and my data in the database was being changed, i would want to know.
What do others think?

From what I see almost 100% of incorrect entries came from networks who went out of business. Mailing them would not be very useful

@arnoldnipper

This comment has been minimized.

Copy link
Contributor

arnoldnipper commented Feb 24, 2018

Q: @vegu Do both IP addresses have to be invalid for the network entry to be removed?

@arnoldnipper yes

@vegu What is the reason behind it? My understanding is, that any false information should be removed. So I would already remove the entry if either address is wrong.

@vegu

This comment has been minimized.

Copy link
Contributor

vegu commented Feb 24, 2018

@arnoldnipper since the ip addresses are what is being used to identify netixlans from ixf data, if one is found the other one can usually be corrected to the correct value, which seemed the reasonable approach to this during implementation, but maybe just dropping it makes more sense?

@arnoldnipper

This comment has been minimized.

Copy link
Contributor

arnoldnipper commented Feb 24, 2018

@vegu for me a logical AND would make more sense: i.e. the entry is valid iff IPv4 address is valid AND IPv6 address is valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment