Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to copy certain fields #567

Open
mcmanuss8 opened this issue Sep 9, 2019 · 5 comments
Open

Click to copy certain fields #567

mcmanuss8 opened this issue Sep 9, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@mcmanuss8
Copy link
Contributor

@mcmanuss8 mcmanuss8 commented Sep 9, 2019

Add some JS to copy a field. Add it to some fields that are commonly copied from the UI:

  • IP addresses & CIDRs
  • ASNs
  • Email addresses
  • Phone #s
@mcmanuss8 mcmanuss8 added the usability label Sep 9, 2019
@eloos

This comment has been minimized.

Copy link

@eloos eloos commented Sep 10, 2019

@mcmanuss8 isn't this cluttering the interface? Are there issues with selecting and copying by mouse??

@mcmanuss8

This comment has been minimized.

Copy link
Contributor Author

@mcmanuss8 mcmanuss8 commented Sep 10, 2019

It wouldn't be a separate button, it would just popup with a tooltip on hover. So you move your mouse over the IP and it would say "Click to copy to clipboard". Clicking it would add it to your clipboard.

@asbjornst

This comment has been minimized.

Copy link

@asbjornst asbjornst commented Sep 12, 2019

Please, only do this on platforms that don't have selection buffers, or make it a user preference.
I don't know if it's enough to just match for X11 in the User-Agent header.

@mcmanuss8 mcmanuss8 self-assigned this Sep 12, 2019
@mcmanuss8

This comment has been minimized.

Copy link
Contributor Author

@mcmanuss8 mcmanuss8 commented Sep 12, 2019

@asbjornst to be clear - are you asking to have the button/feature not show up if the user agent is =~ m/X11/? Is that because selecting the text automatically adds it to the buffer in X11?

@asbjornst

This comment has been minimized.

Copy link

@asbjornst asbjornst commented Sep 12, 2019

@mcmanuss8 Yes, if you select text, then it's automatically stored in the PRIMARY buffer, and it can then be pasted in another window by middle-click, highly useful for terminals. The CLIPBOARD buffer is a separate buffer. Hover boxes and changing the HTML below the mouse is, imho annoying and makes it harder to select the text. When I occasionally uses a someones Windows/Mac machine, I forget that this doesn't work on those platforms.

https://en.wikipedia.org/wiki/X_Window_selection#Clipboard

@arnoldnipper arnoldnipper added this to the Decide milestone Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.